From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Dean Rasheed <dean.a.rasheed@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Lætitia Avrot <laetitia.avrot@gmail.com>
Subject: Re: pgsql: Add support for hyperbolic functions, as well as log10().
Date: Wed, 13 Mar 2019 22:39:03 -0400
Message-ID: <1015.1552531143@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+Tgmoa6Q1MGOnDuFjoJ7mBsatndxnhUNkk8Jv0n6cZS83efcg@mail.gmail.com>
References: <E1h3nUY-0000sM-Vf@gemulon.postgresql.org>
<20190313022159.GR13812@paquier.xyz>
<24813.1552447002@sss.pgh.pa.us>
<20190313050331.GT13812@paquier.xyz>
<17820.1552514192@sss.pgh.pa.us>
<CAEZATCX-mFwmx0NKbGsYJ6RAo8Hb=c+_CeNNXWQ7-BmK2_XVWw@mail.gmail.com>
<27340.1552524529@sss.pgh.pa.us>
<CA+Tgmoa6Q1MGOnDuFjoJ7mBsatndxnhUNkk8Jv0n6cZS83efcg@mail.gmail.com>
Robert Haas <robertmhaas@gmail.com> writes:
> On Wed, Mar 13, 2019 at 8:49 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Meh. As I said before, we're not in the business of improving on what
>> libm does --- if someone has a beef with the results, they need to take
>> it to their platform's libm maintainer, not us. The point of testing
>> this at all is just to ensure that we've wired up the SQL functions
>> to the library functions correctly.
> Pretty sure we don't even need a test for that. asinh() isn't going
> to call creat() by mistake.
No, but that's not the hazard. I have a very fresh-in-mind example:
at one point while tweaking Laetitia's patch, I'd accidentally changed
datanh so that it called tanh not atanh. The previous set of tests did
not reveal that :-(
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com, dean.a.rasheed@gmail.com, michael@paquier.xyz, pgsql-hackers@lists.postgresql.org, laetitia.avrot@gmail.com
Subject: Re: pgsql: Add support for hyperbolic functions, as well as log10().
In-Reply-To: <1015.1552531143@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox