From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Cc: laetitia.avrot@gmail.com
Subject: Re: pgsql: Add support for hyperbolic functions, as well as log10().
Date: Tue, 12 Mar 2019 23:16:42 -0400
Message-ID: <24813.1552447002@sss.pgh.pa.us> (raw)
In-Reply-To: <20190313022159.GR13812@paquier.xyz>
References: <E1h3nUY-0000sM-Vf@gemulon.postgresql.org>
<20190313022159.GR13812@paquier.xyz>
Michael Paquier <michael@paquier.xyz> writes:
> On Tue, Mar 12, 2019 at 07:55:14PM +0000, Tom Lane wrote:
>> Add support for hyperbolic functions, as well as log10().
> jacana is not a fan of this commit, and failed on float8:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=jacana&dt=2019-03-13%2000%3A00%3A27
> @@ -476,7 +476,7 @@
> SELECT asinh(float8 '0');
> asinh
> -------
> - 0
> + -0
> (1 row)
Yeah. I warned Laetitia about not testing corner cases, but
it hadn't occurred to me that zero might be a corner case :-(
I'm inclined to leave it as-is for a day or so and see if any
other failures turn up, before deciding what to do about it.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, pgsql-hackers@lists.postgresql.org, laetitia.avrot@gmail.com
Subject: Re: pgsql: Add support for hyperbolic functions, as well as log10().
In-Reply-To: <24813.1552447002@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox