pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: Teodor Sigaev <teodor@sigaev.ru>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Set random seed for pgbench.
Date: Sat, 31 Mar 2018 12:34:32 -0400
Message-ID: <10686.1522514072@sss.pgh.pa.us> (raw)
In-Reply-To: <alpine.DEB.2.20.1803310828100.23311@lancre>
References: <E1f0U1H-00005J-98@gemulon.postgresql.org>
	<32390.1522464534@sss.pgh.pa.us>
	<alpine.DEB.2.20.1803310828100.23311@lancre>

Fabien COELHO <coelho@cri.ensmp.fr> writes:
>> So this patch has ignored the possibility of not having pg_strong_random.

> I assumed that pg_strong_random is always available,

... which is wrong.  Every other call of it is wrapped in
#ifdef HAVE_STRONG_RANDOM, and so must this one be.
We can use the same error message though, I suppose.

Adjusted and pushed.

			regards, tom lane




view thread (7+ messages)  latest in thread

Message-ID: <10686.1522514072@sss.pgh.pa.us>
Permalink:  ../10686.1522514072@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/10686.1522514072@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, coelho@cri.ensmp.fr, teodor@sigaev.ru, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Set random seed for pgbench.
  In-Reply-To: <10686.1522514072@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox