From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: Teodor Sigaev <teodor@sigaev.ru>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Set random seed for pgbench.
Date: Sun, 01 Apr 2018 12:13:03 -0400
Message-ID: <19794.1522599183@sss.pgh.pa.us> (raw)
In-Reply-To: <20180401072208.GB2211@paquier.xyz>
References: <E1f0U1H-00005J-98@gemulon.postgresql.org>
<32390.1522464534@sss.pgh.pa.us>
<alpine.DEB.2.20.1803310828100.23311@lancre>
<10686.1522514072@sss.pgh.pa.us>
<alpine.DEB.2.20.1803311936450.23311@lancre>
<20180401072208.GB2211@paquier.xyz>
Michael Paquier <michael@paquier.xyz> writes:
> I have not check in details this thread so I may be saying something
> stupid... But if you are looking for a frontend implementation for
> strong randoms, please extract pg_frontend_random in fe-auth-scram.c and
> move it to its own file for example in src/common as a frontend-only
> file. When working on SCRAM, I recall mentioning that but Heikki has
> kept the code in its current shape for simplicity.
I don't really see the point of doing more work than we've done there.
No modern platform should be without pg_strong_random, and if you've
actually had to use --disable-strong-random, it will not be astonishing
that you lose some functionality.
Also, while I personally do not see a use-case why somebody would need
cryptographically strong random seeds in pgbench, if somebody did need
that then they wouldn't thank us for silently falling back to a
not-strong generation method if the platform is misconfigured somehow.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, coelho@cri.ensmp.fr, teodor@sigaev.ru, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Set random seed for pgbench.
In-Reply-To: <19794.1522599183@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox