From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix up misuse of "volatile" in contrib/xml2.
Date: Wed, 09 Jul 2025 11:49:55 -0400
Message-ID: <1141878.1752076195@sss.pgh.pa.us> (raw)
In-Reply-To: <aG2qhGodemZfrxcn@paquier.xyz>
References: <E1uZFQd-005Je7-1t@gemulon.postgresql.org>
<aG2qhGodemZfrxcn@paquier.xyz>
Michael Paquier <michael@paquier.xyz> writes:
> On Tue, Jul 08, 2025 at 09:00:39PM +0000, Tom Lane wrote:
>> Also fix a number of places where variables that are assigned to
>> within a PG_TRY and then used after it were not initialized or
>> not marked as volatile. (A few buildfarm members were issuing
>> "may be used uninitialized" warnings about some of these variables,
>> which is what drew my attention to this area.)
> Oops, thanks. I was not aware of these reports, and the buildfarm was
> not showing any red, the CI looked fine and my machine did not
> complain with a rather new gcc. What were the buildfarm members
> impacted? Did these use a switch and/or a specific compiler that
> helped in detecting these problems?
Not sure. Yesterday I saw such warnings from arowana,
boa, dhole, rhinoceros, and shelduck, eg
arowana | 2025-07-08 04:54:18 | xpath.c:274:6: warning: 'workspace' may be used uninitialized in this function [-Wmaybe-uninitialized]
arowana | 2025-07-08 04:54:18 | xpath.c:319:6: warning: 'workspace' may be used uninitialized in this function [-Wmaybe-uninitialized]
arowana | 2025-07-08 04:54:18 | xpath.c:374:6: warning: 'workspace' may be used uninitialized in this function [-Wmaybe-uninitialized]
arowana | 2025-07-08 04:54:18 | ../../src/include/postgres.h:329:2: warning: 'result' may be used uninitialized in this function [-Wmaybe-uninitialized]
Didn't look to try to figure out what the common factor
among these machines is, but I think all of them are somewhat
dated, which is depressing. You'd hope that newer compilers
are more likely to find such issues, not less likely.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix up misuse of "volatile" in contrib/xml2.
In-Reply-To: <1141878.1752076195@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox