From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix up misuse of "volatile" in contrib/xml2.
Date: Wed, 9 Jul 2025 08:32:20 +0900
Message-ID: <aG2qhGodemZfrxcn@paquier.xyz> (raw)
In-Reply-To: <E1uZFQd-005Je7-1t@gemulon.postgresql.org>
References: <E1uZFQd-005Je7-1t@gemulon.postgresql.org>
On Tue, Jul 08, 2025 at 09:00:39PM +0000, Tom Lane wrote:
> Fix up misuse of "volatile" in contrib/xml2.
>
> Also fix a number of places where variables that are assigned to
> within a PG_TRY and then used after it were not initialized or
> not marked as volatile. (A few buildfarm members were issuing
> "may be used uninitialized" warnings about some of these variables,
> which is what drew my attention to this area.) In most cases
> these variables were being set as the last step within the PG_TRY
> block, which might mean that we could get away without the "volatile"
> marking. But doing that seems unsafe and is definitely not per our
> coding conventions.
>
> These problems seem to have come in with 732061150, so no need
> for back-patch.
Oops, thanks. I was not aware of these reports, and the buildfarm was
not showing any red, the CI looked fine and my machine did not
complain with a rather new gcc. What were the buildfarm members
impacted? Did these use a switch and/or a specific compiler that
helped in detecting these problems?
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix up misuse of "volatile" in contrib/xml2.
In-Reply-To: <aG2qhGodemZfrxcn@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox