From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jacob Champion <jacob.champion@enterprisedb.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix up misuse of "volatile" in contrib/xml2.
Date: Thu, 10 Jul 2025 13:27:59 -0400
Message-ID: <1604720.1752168479@sss.pgh.pa.us> (raw)
In-Reply-To: <CAOYmi+nqgJ9spHTW1dySe=mWtLL07mMY6Z4pzfT2sV+MrNYZFA@mail.gmail.com>
References: <E1uZFQd-005Je7-1t@gemulon.postgresql.org>
<aG2qhGodemZfrxcn@paquier.xyz>
<1141878.1752076195@sss.pgh.pa.us>
<aG85rYItyT0PGr3j@paquier.xyz>
<CAOYmi+nqgJ9spHTW1dySe=mWtLL07mMY6Z4pzfT2sV+MrNYZFA@mail.gmail.com>
Jacob Champion <jacob.champion@enterprisedb.com> writes:
> On Wed, Jul 9, 2025 at 8:55 PM Michael Paquier <michael@paquier.xyz> wrote:
>> On Wed, Jul 09, 2025 at 11:49:55AM -0400, Tom Lane wrote:
>>> Not sure. Yesterday I saw such warnings from arowana,
>>> boa, dhole, rhinoceros, and shelduck, eg
>> They are all using some gcc 4.X flavor, most with -O2 but not all.
> I think I remember that GCC has had historical problems with tuning
> the false-positive:false-negative rates for `-Wmaybe-uninitialized`.
> It's not super surprising to me that later versions aren't always
> better at seeing specific problems, especially if users were
> complaining that an earlier version was too sensitive...
Yeah. Worth noting also is that even the machines that were
complaining were warning about just a subset of the xpath.c functions
that had this problem :-(. So there's definitely some heuristics
involved, which seems odd for what feels like it ought to be a
pretty black-and-white condition.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, jacob.champion@enterprisedb.com, michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix up misuse of "volatile" in contrib/xml2.
In-Reply-To: <1604720.1752168479@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox