From: Tom Lane <tgl@sss.pgh.pa.us>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Merge catalog/pg_foo_fn.h headers back into pg_foo.h headers.
Date: Tue, 10 Apr 2018 12:58:10 -0400
Message-ID: <10009.1523379490@sss.pgh.pa.us> (raw)
In-Reply-To: <CAOBaU_bMq6UNwB6HYo_LWL2kZV=T_VsY9wJW8Wum6Smnppu5MA@mail.gmail.com>
References: <E1f5FAB-0006LU-MB@gemulon.postgresql.org>
<20180409010031.GA11599@paquier.xyz>
<16609.1523243109@sss.pgh.pa.us>
<20180409061354.GD1740@paquier.xyz>
<6629.1523294509@sss.pgh.pa.us>
<17755.1523306794@sss.pgh.pa.us>
<CAOBaU_YH=g68opbbMk8is3jNwhoXGa8ckRSre1nx0Obe1C7i-Q@mail.gmail.com>
<17165.1523367992@sss.pgh.pa.us>
<CAOBaU_bMq6UNwB6HYo_LWL2kZV=T_VsY9wJW8Wum6Smnppu5MA@mail.gmail.com>
Julien Rouhaud <rjuju123@gmail.com> writes:
> On Tue, Apr 10, 2018 at 3:46 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Hm. I wonder if we don't also want NO_TEMP_INSTALL, like the doc/src/sgml
>> makefile. I don't know whether "make check" could be useful in a PGXS
>> build, but certainly that recipe for making a temp install isn't gonna
>> work.
> If I understand correctly, PGXS.mk already forbids a "make check" if
> PGXS is defined. And it seems that postgres' contribs rely on
> including PGXS.mk, setting NO_PGXS and doing a "make check", so
> NO_TEMP_INSTALL shouldn't be needed.
Well, the question that's bothering me is how come "make check" in
an external build doesn't try to execute the temp-install rule before
printing that error message. Experimentation shows that it doesn't,
but it sure looks to me like it should: there's nothing conditional
about the "check: temp-install" dependency in Makefile.global. And
none of the three if-guards in the temp-install rule itself should
prevent this, so what is preventing it? I don't see it.
For this reason, I thought that adding NO_TEMP_INSTALL would be a good
safety factor in case somebody changes/breaks whatever unobvious
thing is keeping this from failing, and so I went ahead and did it.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, rjuju123@gmail.com, michael@paquier.xyz, pgsql-hackers@postgresql.org
Subject: Re: pgsql: Merge catalog/pg_foo_fn.h headers back into pg_foo.h headers.
In-Reply-To: <10009.1523379490@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox