pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Noah Misch <noah@leadboat.com>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Revoke PUBLIC CREATE from public schema, now owned by pg_databas
Date: Fri, 17 Dec 2021 13:41:00 -0500
Message-ID: <1368839.1639766460@sss.pgh.pa.us> (raw)
In-Reply-To: <20211217182518.GA2529654@rfd.leadboat.com>
References: <E1mOaBy-0006mH-1P@gemulon.postgresql.org>
	<1363170.1639763559@sss.pgh.pa.us>
	<20211217182518.GA2529654@rfd.leadboat.com>

Noah Misch <noah@leadboat.com> writes:
> On Fri, Dec 17, 2021 at 12:52:39PM -0500, Tom Lane wrote:
>> It's sort of annoying to fire up a psql+backend
>> for just one command, but perhaps there's other stuff that could be
>> put there too.

> Yes.  The src/test/regress suite would be in a better place if one could run
> most test files via a schedule containing only two files, the setup file and
> the file of interest.  Adding things like the "CREATE TABLE tenk1" to the
> setup file would help that.

If we're thinking of a generalized setup file, putting it after the
tablespace test feels pretty weird.  What was your motivation for
doing this at the end of tablespace.source rather than the start?
It doesn't look like that test in itself had any interesting
dependencies on public not being writable.

			regards, tom lane





view thread (20+ messages)  latest in thread

Message-ID: <1368839.1639766460@sss.pgh.pa.us>
Permalink:  ../1368839.1639766460@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1368839.1639766460@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, noah@leadboat.com
  Subject: Re: pgsql: Revoke PUBLIC CREATE from public schema, now owned by pg_databas
  In-Reply-To: <1368839.1639766460@sss.pgh.pa.us>
  References: <E1mOaBy-0006mH-1P@gemulon.postgresql.org> <1363170.1639763559@sss.pgh.pa.us> <20211217182518.GA2529654@rfd.leadboat.com> <1368839.1639766460@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox