From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: Andres Freund <andres@anarazel.de>
Cc: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: pgsql-hackers@postgresql.org, pgsql-release@postgresql.org, Noah Misch <noah@leadboat.com>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Avoid race in RelationBuildDesc() affecting CREATE INDEX CONCURR
Date: Wed, 09 Feb 2022 00:44:42 -0500
Message-ID: <1370502.1644385482@sss.pgh.pa.us> (raw)
In-Reply-To: <YgMl1YJ1B3n8cGMr@paquier.xyz>
References: <E1meSUe-0004WX-H2@gemulon.postgresql.org>
<df7b4c0b-7d92-f03f-75c4-9e08b269a716@enterprisedb.com>
<20220209004347.mnwaoiv5x7dntuvi@alap3.anarazel.de>
<YgMXej0VBPHcJwVj@paquier.xyz>
<20220209014334.h5pyfbdh2to3v72j@alap3.anarazel.de>
<YgMl1YJ1B3n8cGMr@paquier.xyz>
Michael Paquier <michael@paquier.xyz> writes:
> On Tue, Feb 08, 2022 at 05:43:34PM -0800, Andres Freund wrote:
>> It's stamped, not tagged, so we could send out new tarballs. Or we could skip
>> a release number. IIRC we had to do something along those lines before.
> It does not matter now, but the release is stamped and tagged.
Yeah, I see no need to do anything about this on an emergency
basis.
>> What do you mean with detect here?
> Well, we would not be able to see that something is stuck by default,
> but Noah has just answered to my question by mentioning wait_timeout
> in the buildfarm configuration.
The buildfarm's wait_timeout option isn't that helpful here, because
when it triggers, the client just goes belly-up *with no report*.
So even if the CCA animals had it on, you'd not notice unless you
started to wonder why they'd not reported lately.
I think that's a bug that ought to be fixed. I do agree that
wait_timeout ought to be finite by default, too.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, andrew@dunslane.net, andres@anarazel.de, tomas.vondra@enterprisedb.com, noah@leadboat.com
Subject: Re: pgsql: Avoid race in RelationBuildDesc() affecting CREATE INDEX CONCURR
In-Reply-To: <1370502.1644385482@sss.pgh.pa.us>
References: <E1meSUe-0004WX-H2@gemulon.postgresql.org> <df7b4c0b-7d92-f03f-75c4-9e08b269a716@enterprisedb.com> <20220209004347.mnwaoiv5x7dntuvi@alap3.anarazel.de> <YgMXej0VBPHcJwVj@paquier.xyz> <20220209014334.h5pyfbdh2to3v72j@alap3.anarazel.de> <YgMl1YJ1B3n8cGMr@paquier.xyz> <1370502.1644385482@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox