From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-committers@postgresql.org
Subject: Re: pgsql: Give a better error for duplicate entries in VACUUM/ANALYZE colu
Date: Mon, 25 Sep 2017 15:09:09 -0400
Message-ID: <14181.1506366549@sss.pgh.pa.us> (raw)
In-Reply-To: <862733d5-f132-a59b-7afb-86002f946f80@2ndquadrant.com>
References: <E1dv9jI-0006oT-Fn@gemulon.postgresql.org>
<862733d5-f132-a59b-7afb-86002f946f80@2ndquadrant.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-committers>
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 9/21/17 18:13, Tom Lane wrote:
>> Give a better error for duplicate entries in VACUUM/ANALYZE column list.
> In the error message, we should write "specified more than once" instead
> of "specified twice", because that could otherwise look a bit silly:
> VACUUM ANALYZE vaccluster(i,i,i);
> ERROR: column "i" of relation "vaccluster" is specified twice
OK.
> (Also, the "is" doesn't seem to fit there.)
Hm, reads fine to me, and I'd still rather include "is" in the
revised wording. Anybody else agree with Peter's wording?
regards, tom lane
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, peter.eisentraut@2ndquadrant.com
Subject: Re: pgsql: Give a better error for duplicate entries in VACUUM/ANALYZE colu
In-Reply-To: <14181.1506366549@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox