pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Change timeline field of IDENTIFY_SYSTEM to int8
Date: Mon, 04 Jul 2022 01:55:13 -0400
Message-ID: <1467434.1656914113@sss.pgh.pa.us> (raw)
In-Reply-To: <E1o8EnP-0016rA-Kx@gemulon.postgresql.org>
References: <E1o8EnP-0016rA-Kx@gemulon.postgresql.org>

Peter Eisentraut <peter@eisentraut.org> writes:
> Change timeline field of IDENTIFY_SYSTEM to int8

Surely this patch is far from complete?

To start with, just a few lines down in IdentifySystem() the column
is filled using Int32GetDatum not Int64GetDatum.  I will get some
popcorn and await the opinions of the 32-bit buildfarm animals.

But what about whatever code is reading the output?  And what if
that code isn't v16?  I can't believe that we can make a wire
protocol change as summarily as this.

			regards, tom lane





view thread (7+ messages)  latest in thread

Message-ID: <1467434.1656914113@sss.pgh.pa.us>
Permalink:  ../1467434.1656914113@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1467434.1656914113@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, peter@eisentraut.org
  Subject: Re: pgsql: Change timeline field of IDENTIFY_SYSTEM to int8
  In-Reply-To: <1467434.1656914113@sss.pgh.pa.us>
  References: <E1o8EnP-0016rA-Kx@gemulon.postgresql.org> <1467434.1656914113@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox