pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter@eisentraut.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Change timeline field of IDENTIFY_SYSTEM to int8
Date: Tue, 5 Jul 2022 09:49:07 +0900
Message-ID: <YsOKgyhZRXfjts3A@paquier.xyz> (raw)
In-Reply-To: <1467434.1656914113@sss.pgh.pa.us>
References: <E1o8EnP-0016rA-Kx@gemulon.postgresql.org>
	<1467434.1656914113@sss.pgh.pa.us>

On Mon, Jul 04, 2022 at 01:55:13AM -0400, Tom Lane wrote:
> Peter Eisentraut <peter@eisentraut.org> writes:
> > Change timeline field of IDENTIFY_SYSTEM to int8
> 
> Surely this patch is far from complete?

Yeah..

> But what about whatever code is reading the output?  And what if
> that code isn't v16?  I can't believe that we can make a wire
> protocol change as summarily as this.

Assuming that one reaches a timeline of 2 billion, this change would
make the TLI consumption of the client safe to signedness.  But why is
it safe to do a protocol change when running IDENTIFY_SYSTEM?  We've
been very strict to maintain compatibility for any protocol change,
hence why should the replication protocol be treated differently?
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (7+ messages)

Message-ID: <YsOKgyhZRXfjts3A@paquier.xyz>
Permalink:  ../YsOKgyhZRXfjts3A@paquier.xyz/
Also on:    postgresql.org/message-id/YsOKgyhZRXfjts3A@paquier.xyz

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, peter@eisentraut.org
  Subject: Re: pgsql: Change timeline field of IDENTIFY_SYSTEM to int8
  In-Reply-To: <YsOKgyhZRXfjts3A@paquier.xyz>
  References: <E1o8EnP-0016rA-Kx@gemulon.postgresql.org> <1467434.1656914113@sss.pgh.pa.us> <YsOKgyhZRXfjts3A@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox