From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add copy/equal support for XID lists
Date: Tue, 12 Jul 2022 10:36:45 -0400
Message-ID: <1548311.1657636605@sss.pgh.pa.us> (raw)
In-Reply-To: <E1oBGd6-002RcV-0D@gemulon.postgresql.org>
References: <E1oBGd6-002RcV-0D@gemulon.postgresql.org>
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> Add copy/equal support for XID lists
What about outfuncs/readfuncs? I see that you fixed _outList,
but not its caller outNode:
else if (IsA(obj, List) || IsA(obj, IntList) || IsA(obj, OidList))
_outList(str, obj);
and the LEFT_PAREN case in nodeRead() doesn't know what to do either.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, alvherre@alvh.no-ip.org
Subject: Re: pgsql: Add copy/equal support for XID lists
In-Reply-To: <1548311.1657636605@sss.pgh.pa.us>
References: <E1oBGd6-002RcV-0D@gemulon.postgresql.org> <1548311.1657636605@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox