From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add copy/equal support for XID lists
Date: Tue, 12 Jul 2022 20:35:16 +0200
Message-ID: <20220712183516.cmdowamk7eqahmjw@alvherre.pgsql> (raw)
In-Reply-To: <1548311.1657636605@sss.pgh.pa.us>
On 2022-Jul-12, Tom Lane wrote:
> What about outfuncs/readfuncs? I see that you fixed _outList,
> but not its caller outNode:
>
> else if (IsA(obj, List) || IsA(obj, IntList) || IsA(obj, OidList))
> _outList(str, obj);
>
> and the LEFT_PAREN case in nodeRead() doesn't know what to do either.
Hmm, true -- naively grepping for OidList wasn't enough (moreso when I
failed to notice one occurrence). This patch closes the holes you
mentioned. I haven't found any others yet.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"La vida es para el que se aventura"
Attachments:
0001-Fix-XID-list-support-some-more.patch (text/x-diff, 0B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: alvherre@alvh.no-ip.org, tgl@sss.pgh.pa.us
Subject: Re: pgsql: Add copy/equal support for XID lists
In-Reply-To: <20220712183516.cmdowamk7eqahmjw@alvherre.pgsql>
References: <1548311.1657636605@sss.pgh.pa.us> <20220712183516.cmdowamk7eqahmjw@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox