From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Change timeline field of IDENTIFY_SYSTEM to int8
Date: Mon, 04 Jul 2022 13:32:43 -0400
Message-ID: <1598591.1656955963@sss.pgh.pa.us> (raw)
In-Reply-To: <e92dec6f-4b73-07ec-2dc9-9c67db92a929@enterprisedb.com>
References: <E1o8EnP-0016rA-Kx@gemulon.postgresql.org>
<1467434.1656914113@sss.pgh.pa.us>
<e92dec6f-4b73-07ec-2dc9-9c67db92a929@enterprisedb.com>
Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
> On 04.07.22 07:55, Tom Lane wrote:
>> But what about whatever code is reading the output? And what if
>> that code isn't v16? I can't believe that we can make a wire
>> protocol change as summarily as this.
> I think a client will either just read the string value and convert it
> to some numeric type without checking what type was actually sent, or if
> the client API is type-aware and automatically converts to a native type
> of some sort, then it will probably already support 64-bit ints. Do you
> see some problem scenario?
If the result of IDENTIFY_SYSTEM is always sent in text format, then
I agree that this isn't very problematic. If there are any clients
that fetch it in binary mode, though, this is absolutely a wire
protocol break for them ... and no, I don't believe an unsupported
claim that they'd adapt automatically.
> I'm seeing a bigger problem now, which is that our client code doesn't
> parse bigger-than-int32 timeline IDs correctly.
Yup.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, peter.eisentraut@enterprisedb.com, pgsql-hackers@postgresql.org
Subject: Re: pgsql: Change timeline field of IDENTIFY_SYSTEM to int8
In-Reply-To: <1598591.1656955963@sss.pgh.pa.us>
References: <E1o8EnP-0016rA-Kx@gemulon.postgresql.org> <1467434.1656914113@sss.pgh.pa.us> <e92dec6f-4b73-07ec-2dc9-9c67db92a929@enterprisedb.com> <1598591.1656955963@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox