From: Daniel Gustafsson <daniel@yesql.se>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Amit Kapila <akapila@postgresql.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgsql: Remove unused wait events.
Date: Mon, 25 Oct 2021 19:34:37 +0200
Message-ID: <1611CCCC-E0E8-4A74-A95B-80ECCE987145@yesql.se> (raw)
In-Reply-To: <4050629.1635182306@sss.pgh.pa.us>
References: <E1mdOBY-0005j2-QL@gemulon.postgresql.org>
<CA+TgmoYSAsxiHqpyDCzJa2-hYv0Sme7Me1esi6sHG6LbY8KD+w@mail.gmail.com>
<4047667.1635179918@sss.pgh.pa.us>
<CA+TgmoZ2W5Pqq19kzN5K-Boveq0u1v5az7wFJcUhHdZ18aw7_A@mail.gmail.com>
<4050629.1635182306@sss.pgh.pa.us>
> On 25 Oct 2021, at 19:18, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Robert Haas <robertmhaas@gmail.com> writes:
>> ... But while I agree it's good to remove unused stuff in the
>> master, it doesn't seem like we really need to back-patch it.
>
> Yeah, exactly. I don't see any benefit that's commensurate with
> even a small risk of breaking extensions --- and apparently, in
> this case that's not a risk but a certainty.
Since this will cause integer values to have different textual enum value
representations in 14 and 15+, do we want to skip two numbers by assigning the
next wait event the integer value of WAIT_EVENT_WAL_WRITE incremented by three?
Or enum integer reuse not something we guarantee against across major versions?
--
Daniel Gustafsson https://vmware.com/
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: daniel@yesql.se, tgl@sss.pgh.pa.us, robertmhaas@gmail.com, akapila@postgresql.org, pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Remove unused wait events.
In-Reply-To: <1611CCCC-E0E8-4A74-A95B-80ECCE987145@yesql.se>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox