pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alexander Korotkov <aekorotkov@gmail.com>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Alexander Korotkov <akorotkov@postgresql.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Detecting pointer misalignment (was Re: pgsql: Implementation of subscripting for jsonb)
Date: Sat, 13 Feb 2021 17:59:09 -0500
Message-ID: <1870527.1613257149@sss.pgh.pa.us> (raw)
In-Reply-To: <1611008.1613170500@sss.pgh.pa.us>
References: <E1l6Jjn-0000kp-75@gemulon.postgresql.org>
	<37bb56a0-391d-759d-771b-9c1d8c15a84b@iki.fi>
	<3293925.1612163110@sss.pgh.pa.us>
	<CAPpHfdsne3=T=fMNU45PtxdhSL_J2PjLTeS8rwKnJzUR4YNd4w@mail.gmail.com>
	<CAPpHfdu8Jh0tySa50Zhkyg6gMvi2pQFdHAMiF+UkZNqsDLwTQw@mail.gmail.com>
	<475514.1612745257@sss.pgh.pa.us>
	<CAPpHfdvh+QrbBCo=uY=_fHK8w7yKr=Q4KGAtp=3tzp62SjODrA@mail.gmail.com>
	<CA+hUKGLs9xMUDY=Oh0uOyJysaY=NGg3y53q_Tr2C+LLqstYf6A@mail.gmail.com>
	<CAPpHfduDEYtWEB+xhM3PcP4bFwJ3aqZw7R7xFto8+pVDV5w-MA@mail.gmail.com>
	<1557041.1613150383@sss.pgh.pa.us>
	<CAPpHfdtEeg4Ax09kCHGupiG8rUuL1EAhdHUdbjCxM=JgrSCoDw@mail.gmail.com>
	<1611008.1613170500@sss.pgh.pa.us>

I wrote:
> Alexander Korotkov <aekorotkov@gmail.com> writes:
>> On Fri, Feb 12, 2021 at 8:19 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> Once this does settle, should we consider back-patching so that it's
>>> possible to run alignment checks in the back branches too?

>> +1

> Let's make sure we have a clean set of builds and then do that.

The buildfarm seems to be happy --- the active members that haven't
reported in should be unaffected by this patch, either because their
compiler versions are too old or because they're not x86 architecture.
So I went ahead and back-patched, and have adjusted longfin to apply
the -fsanitize switch in all branches.

(I've checked that 9.6 passes check-world this way, but not the
intermediate branches, so it's possible something will fail...)

			regards, tom lane





view thread (15+ messages)  latest in thread

Message-ID: <1870527.1613257149@sss.pgh.pa.us>
Permalink:  ../1870527.1613257149@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1870527.1613257149@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, aekorotkov@gmail.com, thomas.munro@gmail.com, hlinnaka@iki.fi, akorotkov@postgresql.org, pgsql-hackers@lists.postgresql.org
  Subject: Re: Detecting pointer misalignment (was Re: pgsql: Implementation of subscripting for jsonb)
  In-Reply-To: <1870527.1613257149@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox