From: Tom Lane <tgl@sss.pgh.pa.us>
To: Noah Misch <noah@leadboat.com>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: pgsql-hackers@lists.postgresql.org, Craig Ringer <craig.ringer@enterprisedb.com>
Subject: Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3.
Date: Thu, 07 Oct 2021 23:39:11 -0400
Message-ID: <197091.1633664351@sss.pgh.pa.us> (raw)
In-Reply-To: <20211008025659.GA398563@rfd.leadboat.com>
References: <E1mYY6Z-0006OL-QN@gemulon.postgresql.org>
<150C7533-8A64-4829-ABEA-50F0D49FC598@yesql.se>
<161525.1633632402@sss.pgh.pa.us>
<162421.1633633360@sss.pgh.pa.us>
<12C3DA75-ACE1-486B-A432-9E23C68E7D34@yesql.se>
<173186.1633635888@sss.pgh.pa.us>
<20211008025659.GA398563@rfd.leadboat.com>
Noah Misch <noah@leadboat.com> writes:
> On Thu, Oct 07, 2021 at 03:44:48PM -0400, Tom Lane wrote:
>>> (1) I'm distrustful of the idea that perl 5.8.x will compile
>>> cleanly, or at all, on modern platforms. Certainly Postgres
>>> releases of similar vintage won't.
> perlbrew uses the patchperl system to build old Perl in modern environments.
> This year, I used it to get 5.8.0. Building unpatched 5.8.0 does fail.
Oh, cool.
>> I propose that what might be more useful than the existing last
>> section of src/test/perl/README is something along the lines of:
> -1. This would replace a useful recipe with, essentially, a restatement of
> that recipe in English words. That just leaves the user to rediscover the
> actual recipe.
Well, I think the existing text does the reader a disservice
by stating a specific recipe without any context. Notably,
it says nothing about restricting which Perl modules you use.
What do you think of using my proposed text followed by
One way to test against an old Perl version is to use
perlbrew.
<< more or less the existing text here >>
Bear in mind that you will still need to install IPC::Run,
and what you will get is a current version not the one
distributed with Perl 5.8.3. You will also need to update
Test::More because the version distributed with Perl 5.8.3
is too old to run our TAP tests. So this recipe does not create
a perfect reproduction of a back-in-the-day Perl installation,
but it will probably catch any problems that might surface in
the buildfarm.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, noah@leadboat.com, daniel@yesql.se, craig.ringer@enterprisedb.com
Subject: Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3.
In-Reply-To: <197091.1633664351@sss.pgh.pa.us>
References: <E1mYY6Z-0006OL-QN@gemulon.postgresql.org> <150C7533-8A64-4829-ABEA-50F0D49FC598@yesql.se> <161525.1633632402@sss.pgh.pa.us> <162421.1633633360@sss.pgh.pa.us> <12C3DA75-ACE1-486B-A432-9E23C68E7D34@yesql.se> <173186.1633635888@sss.pgh.pa.us> <20211008025659.GA398563@rfd.leadboat.com> <197091.1633664351@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox