From: Noah Misch <noah@leadboat.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: pgsql-hackers@lists.postgresql.org, Craig Ringer <craig.ringer@enterprisedb.com>
Subject: Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3.
Date: Thu, 7 Oct 2021 19:56:59 -0700
Message-ID: <20211008025659.GA398563@rfd.leadboat.com> (raw)
In-Reply-To: <173186.1633635888@sss.pgh.pa.us>
References: <E1mYY6Z-0006OL-QN@gemulon.postgresql.org>
<150C7533-8A64-4829-ABEA-50F0D49FC598@yesql.se>
<161525.1633632402@sss.pgh.pa.us>
<162421.1633633360@sss.pgh.pa.us>
<12C3DA75-ACE1-486B-A432-9E23C68E7D34@yesql.se>
<173186.1633635888@sss.pgh.pa.us>
On Thu, Oct 07, 2021 at 03:44:48PM -0400, Tom Lane wrote:
> [ cc'ing Craig and Noah, as author/committer of the existing text ]
>
> Daniel Gustafsson <daniel@yesql.se> writes:
> > On 7 Oct 2021, at 21:02, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> >> BTW, looking at that a second time, I wonder if that advice is
> >> really of any use.
> >>
> >> (1) I'm distrustful of the idea that perl 5.8.x will compile
> >> cleanly, or at all, on modern platforms. Certainly Postgres
> >> releases of similar vintage won't.
perlbrew uses the patchperl system to build old Perl in modern environments.
This year, I used it to get 5.8.0. Building unpatched 5.8.0 does fail.
> >> (2) Unless perlbrew.pl is doing something a lot more magic than
> >> I think, you're going to end up with current-not-historical
> >> versions of whatever it has to pull from CPAN. That's going
> >> to include at least IPC::Run and Test::More if you want to run
> >> our TAP tests.
Yes. If someone changed the recipe to install Test::More 0.87 and the
oldest-acceptable IPC::Run, we'd detect more portability problems. I'd regard
such a change as an improvement.
> >> So maybe this advice is helpful, but I'm not very convinced.
The rest of this thread is leaning on the above misconceptions:
> I propose that what might be more useful than the existing last
> section of src/test/perl/README is something along the lines of:
>
> Avoid using any bleeding-edge Perl features. We have buildfarm
> animals running Perl versions as old as 5.8.3, so your tests will
> be expected to pass on that.
>
> Also, do not use any non-core Perl modules except IPC::Run.
> Or, if you must do so for a particular test, arrange to skip
> the test when the needed module isn't present.
-1. This would replace a useful recipe with, essentially, a restatement of
that recipe in English words. That just leaves the user to rediscover the
actual recipe.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: noah@leadboat.com, tgl@sss.pgh.pa.us, daniel@yesql.se, craig.ringer@enterprisedb.com
Subject: Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3.
In-Reply-To: <20211008025659.GA398563@rfd.leadboat.com>
References: <E1mYY6Z-0006OL-QN@gemulon.postgresql.org> <150C7533-8A64-4829-ABEA-50F0D49FC598@yesql.se> <161525.1633632402@sss.pgh.pa.us> <162421.1633633360@sss.pgh.pa.us> <12C3DA75-ACE1-486B-A432-9E23C68E7D34@yesql.se> <173186.1633635888@sss.pgh.pa.us> <20211008025659.GA398563@rfd.leadboat.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox