pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Make new strings more alike previously existing messages.
4+ messages / 4 participants
[nested] [flat]
* pgsql: Make new strings more alike previously existing messages.
@ 2009-04-13 21:03 Alvaro Herrera <alvherre@postgresql.org>
0 siblings, 1 reply; 4+ messages in thread
From: alvherre@postgresql.org @ 2009-04-13 21:03 UTC (permalink / raw)
To: pgsql-committers
Log Message:
-----------
Make new strings more alike previously existing messages.
Modified Files:
--------------
pgsql/src/bin/pg_dump:
pg_restore.c (r1.97 -> r1.98)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_dump/pg_restore.c?r1=1.97&r2=1.98)
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pgsql: Make new strings more alike previously existing messages.
@ 2009-04-13 22:57 Tom Lane <tgl@sss.pgh.pa.us>
parent: Alvaro Herrera <alvherre@postgresql.org>
0 siblings, 1 reply; 4+ messages in thread
From: Tom Lane @ 2009-04-13 22:57 UTC (permalink / raw)
To: Alvaro Herrera <alvherre@commandprompt.com>; +Cc: pgsql-committers
alvherre@postgresql.org (Alvaro Herrera) writes:
> Make new strings more alike previously existing messages.
This patch changed the meaning of one of the messages:
*************** main(int argc, char **argv)
*** 316,322 ****
/* Can't do single-txn mode with multiple connections */
if (opts->single_txn && opts->number_of_jobs > 1)
{
! fprintf(stderr, _("%s: cannot specify both --single-transaction and multiple jobs\n"),
progname);
exit(1);
}
--- 316,322 ----
/* Can't do single-txn mode with multiple connections */
if (opts->single_txn && opts->number_of_jobs > 1)
{
! fprintf(stderr, _("%s: options -1/--single-transaction and -j/--jobs cannot be used together\n"),
progname);
exit(1);
}
As the comment and the code itself show, "-j 1" works just fine with
--single-transaction. The original wording reflected that, the new does
not.
Maybe this amount of imprecision is acceptable, but "make it look more
like the other messages" doesn't seem to me like enough justification.
regards, tom lane
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pgsql: Make new strings more alike previously existing messages.
@ 2009-04-14 00:06 Alvaro Herrera <alvherre@commandprompt.com>
parent: Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 4+ messages in thread
From: Alvaro Herrera @ 2009-04-14 00:06 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: pgsql-committers
Tom Lane wrote:
> /* Can't do single-txn mode with multiple connections */
> if (opts->single_txn && opts->number_of_jobs > 1)
> {
> ! fprintf(stderr, _("%s: options -1/--single-transaction and -j/--jobs cannot be used together\n"),
> progname);
> exit(1);
> }
>
> As the comment and the code itself show, "-j 1" works just fine with
> --single-transaction. The original wording reflected that, the new does
> not.
Hmm, I didn't realize that you could usefully pass -j1 ... now I realize
that it even works in Make. You're right, the new message is bogus.
I'll revert this part.
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Adjust documentation for syncfs().
@ 2024-03-27 15:24 Nathan Bossart <nathan@postgresql.org>
0 siblings, 0 replies; 4+ messages in thread
From: Nathan Bossart @ 2024-03-27 15:24 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Adjust documentation for syncfs().
Commit 8c16ad3b43 created a new appendix for syncfs(), which is
excessive for such a small amount of content. This commit moves
the description of the caveats to be aware of when using syncfs()
back to the documentation for recovery_init_sync_method. The
documentation for the other utilities with syncfs() support now
directs readers to recovery_init_sync_method for information about
these caveats.
Reported-by: Peter Eisentraut, Robert Haas
Suggested-by: Robert Haas
Reviewed-by: Robert Haas
Discussion: https://postgr.es/m/42804669-7063-1320-ed37-3226d5f1067d%40eisentraut.org
Discussion: https://postgr.es/m/CA%2BTgmobUiqKr%2BZMCLc5Qap-sXBnjfGUU%2BZBmzYEjUuWyjsGr1g%40mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/44a4cca9913bae8557c31207adb97b94e6e60603
Modified Files
--------------
doc/src/sgml/config.sgml | 12 +++++++++---
doc/src/sgml/filelist.sgml | 1 -
doc/src/sgml/postgres.sgml | 1 -
doc/src/sgml/ref/initdb.sgml | 4 ++--
doc/src/sgml/ref/pg_basebackup.sgml | 4 ++--
doc/src/sgml/ref/pg_checksums.sgml | 4 ++--
doc/src/sgml/ref/pg_combinebackup.sgml | 4 ++--
doc/src/sgml/ref/pg_dump.sgml | 5 +++--
doc/src/sgml/ref/pg_rewind.sgml | 4 ++--
doc/src/sgml/ref/pgupgrade.sgml | 4 ++--
doc/src/sgml/syncfs.sgml | 36 ----------------------------------
11 files changed, 24 insertions(+), 55 deletions(-)
^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2024-03-27 15:24 UTC | newest]
Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2009-04-13 21:03 pgsql: Make new strings more alike previously existing messages. Alvaro Herrera <alvherre@postgresql.org>
2009-04-13 22:57 ` Tom Lane <tgl@sss.pgh.pa.us>
2009-04-14 00:06 ` Alvaro Herrera <alvherre@commandprompt.com>
2024-03-27 15:24 pgsql: Adjust documentation for syncfs(). Nathan Bossart <nathan@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox