From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: Peter Eisentraut <peter_e@gmx.net>
Cc: Fujii Masao <fujii@postgresql.org>
Cc: pgsql-committers@postgresql.org
Subject: Re: pgsql: Mark the second argument of pg_log as the translatable string in
Date: Mon, 13 Apr 2015 14:17:05 -0300
Message-ID: <20150413171705.GQ4369@alvh.no-ip.org> (raw)
In-Reply-To: <CAB7nPqQP8NU3WztTG8Snd4k2S5dLx1CN0dRCzcuFF1GuyqJATQ@mail.gmail.com>
References: <E1YffOB-0006ry-RI@gemulon.postgresql.org>
<5529C5A7.3070708@gmx.net>
<20150412011715.GK4369@alvh.no-ip.org>
<CAB7nPqQP8NU3WztTG8Snd4k2S5dLx1CN0dRCzcuFF1GuyqJATQ@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-committers>
Michael Paquier wrote:
> On Sun, Apr 12, 2015 at 10:17 AM, Alvaro Herrera wrote:
> > What pg_basebackup's progress_report() does is have the message in the
> > translatable part not include the \r; the \r is in a separate fprintf()
> > call.
>
> Like the attached then.
Not a fan of this approach, because now this function knows that
pg_log(PG_PROGRESS) is equivalent to printf(). This abstraction is a
bit leaky, isn't it ... Probably not worth sweating about, though.
> diff --git a/src/bin/pg_rewind/logging.c b/src/bin/pg_rewind/logging.c
> index aba12d8..3e2dc76 100644
> --- a/src/bin/pg_rewind/logging.c
> +++ b/src/bin/pg_rewind/logging.c
> @@ -134,7 +134,8 @@ progress_report(bool force)
> snprintf(fetch_size_str, sizeof(fetch_size_str), INT64_FORMAT,
> fetch_size / 1024);
>
> - pg_log(PG_PROGRESS, "%*s/%s kB (%d%%) copied\r",
> + pg_log(PG_PROGRESS, "%*s/%s kB (%d%%) copied",
> (int) strlen(fetch_size_str), fetch_done_str, fetch_size_str,
> percent);
> + printf("\r");
> }
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: alvherre@2ndquadrant.com, michael.paquier@gmail.com, peter_e@gmx.net, fujii@postgresql.org
Subject: Re: pgsql: Mark the second argument of pg_log as the translatable string in
In-Reply-To: <20150413171705.GQ4369@alvh.no-ip.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox