From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Michael Paquier <michael.paquier@gmail.com>
Cc: Kevin Grittner <kgrittn@ymail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: Re: [COMMITTERS] pgsql: Retain comments on indexes and constraints at ALTER TABLE ... TY
Date: Mon, 20 Jul 2015 11:25:17 +0200
Message-ID: <20150720092517.GH2301@postgresql.org> (raw)
In-Reply-To: <20150720084146.GF2301@postgresql.org>
References: <E1ZEvoc-0002RV-Vh@gemulon.postgresql.org>
<81620362.883169.1437142581761.JavaMail.yahoo@mail.yahoo.com>
<CAB7nPqTnAyTwrnXfyJdmovu0B991KK3tymgW5NNtPWyU=fhNzQ@mail.gmail.com>
<55A94C2D.1010204@iki.fi>
<20150718131528.GV2301@postgresql.org>
<55ACA793.7080400@iki.fi>
<20150720084146.GF2301@postgresql.org>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Alvaro Herrera wrote:
> Heikki Linnakangas wrote:
> > On 07/18/2015 04:15 PM, Alvaro Herrera wrote:
> > >Heikki Linnakangas wrote:
> > >>If it's there just to so you can run the regression tests that come
> > >>with it, it might make sense to just add a "default" case to that
> > >>switch to handle any unrecognized commands, and perhaps even remove
> > >>the cases for the currently untested subcommands as it's just dead
> > >>code.
> > >
> > >Well, I would prefer to have an output that says "unrecognized" and then
> > >add more test cases to the SQL files so that there's not so much dead
> > >code. I prefer that to removing the C support code, because then as
> > >we add extra tests we don't need to modify the C source.
> >
> > Ok. I added a case for AT_ReAddComment, and also a default-case that says
> > "unrecognized".
>
> Oh, sorry, I forgot to tell you that I was working on it.
I pushed the remaining part of my patch. Thanks for fixing the other
bits.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: alvherre@2ndquadrant.com, hlinnaka@iki.fi, michael.paquier@gmail.com, kgrittn@ymail.com, pgsql-hackers@postgresql.org
Subject: Re: Re: [COMMITTERS] pgsql: Retain comments on indexes and constraints at ALTER TABLE ... TY
In-Reply-To: <20150720092517.GH2301@postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox