From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@postgresql.org
Subject: Re: pgsql: Remove BufFile's isTemp flag.
Date: Thu, 16 Nov 2017 19:11:49 -0800
Message-ID: <20171117031149.hslkxis732hkjuog@alap3.anarazel.de> (raw)
In-Reply-To: <23339.1510887494@sss.pgh.pa.us>
References: <E1eFVyl-0008J1-RO@gemulon.postgresql.org>
<23339.1510887494@sss.pgh.pa.us>
On 2017-11-16 21:58:14 -0500, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > Remove BufFile's isTemp flag.
> > The isTemp flag controls whether buffile.c chops BufFile data up into
> > 1GB segments on disk. Since it was badly named and always true, get
> > rid of it.
>
> [ squint... ] That used to have an actual purpose connected to
> transaction-abort cleanup, IIRC. It disturbs me that this seems
> to have been
I've not found any such use, searching through buffile.c's history. I
don't quite see how that flag could've been related to abort cleanup
stuff? There's been another unused caller of makeBufFile, namely
BufFileCreate, that has been #ifdef'ed out for ages (perhaps we
should've removed that with this commit or a long time ago). Other than
that there seems to not have been any other caller setting that flag
differently since you created the file in db3c4c3a2d980dcd.
Greetings,
Andres Freund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: andres@anarazel.de, tgl@sss.pgh.pa.us
Subject: Re: pgsql: Remove BufFile's isTemp flag.
In-Reply-To: <20171117031149.hslkxis732hkjuog@alap3.anarazel.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox