From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Postgres hackers <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Merge catalog/pg_foo_fn.h headers back into pg_foo.h headers.
Date: Tue, 10 Apr 2018 11:59:43 +0900
Message-ID: <20180410025943.GA1945@paquier.xyz> (raw)
In-Reply-To: <17755.1523306794@sss.pgh.pa.us>
References: <E1f5FAB-0006LU-MB@gemulon.postgresql.org>
<20180409010031.GA11599@paquier.xyz>
<16609.1523243109@sss.pgh.pa.us>
<20180409061354.GD1740@paquier.xyz>
<6629.1523294509@sss.pgh.pa.us>
<17755.1523306794@sss.pgh.pa.us>
On Mon, Apr 09, 2018 at 04:46:34PM -0400, Tom Lane wrote:
> After further contemplation I decided that that was, in fact, the only
> reasonable way to improve matters. If we have multiple subdirectories
> independently firing the "make generated-headers" action, then we have
> parallel make hazards of just the same sort I was trying to prevent.
> So it's really an all-or-nothing proposition. The MAKELEVEL hack
> plus wiring the prerequisite into the recursion rules is the best way
> to make that happen.
Oh. Good idea. Thanks for the fix. Hopefully that won't cause much
noise when bisecting bugs, this got in pretty quickly..
No more complains from here.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../20180410025943.GA1945@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, pgsql-hackers@postgresql.org
Subject: Re: pgsql: Merge catalog/pg_foo_fn.h headers back into pg_foo.h headers.
In-Reply-To: <20180410025943.GA1945@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox