From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Rework option set of vacuumlo
Date: Tue, 28 Aug 2018 14:37:01 -0700
Message-ID: <20180828213701.GL29157@paquier.xyz> (raw)
In-Reply-To: <17758.1535490505@sss.pgh.pa.us>
References: <E1fudM8-0000af-Lm@gemulon.postgresql.org>
<12438.1535488750@sss.pgh.pa.us>
<17758.1535490505@sss.pgh.pa.us>
On Tue, Aug 28, 2018 at 05:08:25PM -0400, Tom Lane wrote:
> I wrote:
>> Digging, this is because the "make check" processing isn't actually
>> installing oid2name (resp. vacuumlo) into the temp installation tree :-(.
>>
>> I don't think this is the fault of your tests, exactly --- there's
>> something wrong in the existing make rules. I'm not sure what though.
>> EXTRA_INSTALL should be getting set, according to pgxs.mk:
>> temp-install: EXTRA_INSTALL+=$(subdir)
>> but it evidently isn't.
>
> Oh! The reason why not is that that line is inside "ifdef REGRESS",
> and these subdirectories have no REGRESS tests. So we should move
> that out to where it will apply regardless of that. Will fix.
Yes, I was going to send a patch along the same lines as what you have
just committed. Thanks! It looks that the binary was installed in my
own PATH, so I did not notice it.
This should definitely get back-patched in my opinion, I have similar
problems with pg_rewind tests of 9.3 and 9.4 that I still maintain out
of the core tree, where the main binary needs to be installed first. In
this case I just used some Makefile trick.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, peter.eisentraut@2ndquadrant.com, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Rework option set of vacuumlo
In-Reply-To: <20180828213701.GL29157@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox