From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org, Andrew Dunstan <andrew@dunslane.net>
Subject: Re: pgsql: Allow concurrent-safe open() and fopen() in frontend code for Wi
Date: Mon, 17 Sep 2018 23:02:02 +0900
Message-ID: <20180917140202.GF31460@paquier.xyz> (raw)
In-Reply-To: <17194.1537191697@sss.pgh.pa.us>
References: <E1g0cYN-0003oE-IE@gemulon.postgresql.org>
<23543.1536938575@sss.pgh.pa.us>
<20180914224939.GA1178@paquier.xyz>
<20180917114113.GA31460@paquier.xyz>
<17194.1537191697@sss.pgh.pa.us>
On Mon, Sep 17, 2018 at 09:41:37AM -0400, Tom Lane wrote:
> BTW, I'm a bit concerned by the fact that bowerbird has failed its
> last couple of HEAD runs at the pgbench step. The first such
> failure was here:
>
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bowerbird&dt=2018-09-15%2014%3A19%3A58
>
> Looking at the set of commits between the prior run and that one,
> it's hard to see anything that could have triggered the test failures
> other than this patch --- but I also don't see how this patch would've
> blown up pgbench without breaking earlier tests. Ideas?
Thanks, I have been looking at the build farm but I missed this one.
dory, which uses VS 2015 is not complaining because it does not run
bincheck. At quick glance, it seems to be caused by process_file() in
pgbench.c which would need to open files in text mode, and the input
file parsing fails at the first '\' character found. I'll test that
stuff on tomorrow morning manually.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../20180917140202.GF31460@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, andrew@dunslane.net
Subject: Re: pgsql: Allow concurrent-safe open() and fopen() in frontend code for Wi
In-Reply-To: <20180917140202.GF31460@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox