From: Stephen Frost <sfrost@snowman.net>
To: Andres Freund <andres@anarazel.de>
Cc: Andrew Gierth <andrew@tao11.riddles.org.uk>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Christoph Berg <myon@debian.org>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: UCT (Re: pgsql: Update time zone data files to tzdata release 2019a.)
Date: Mon, 17 Jun 2019 14:40:53 -0400
Message-ID: <20190617184053.GI2480@tamriel.snowman.net> (raw)
In-Reply-To: <20190617183828.hj7ci362zbxd4nax@alap3.anarazel.de>
References: <24452.1560285699@sss.pgh.pa.us>
<20190614095546.GA15107@msg.df7cb.de>
<26948.1560517875@sss.pgh.pa.us>
<87ef3w3u8a.fsf@news-spur.riddles.org.uk>
<7114.1560539536@sss.pgh.pa.us>
<875zp74zpf.fsf@news-spur.riddles.org.uk>
<871rzv4yes.fsf@news-spur.riddles.org.uk>
<20190617173943.z3ttxqenbcwrlag4@alap3.anarazel.de>
<20190617183458.GG2480@tamriel.snowman.net>
<20190617183828.hj7ci362zbxd4nax@alap3.anarazel.de>
Greetings,
* Andres Freund (andres@anarazel.de) wrote:
> On 2019-06-17 14:34:58 -0400, Stephen Frost wrote:
> > * Andres Freund (andres@anarazel.de) wrote:
> > > On 2019-06-14 23:14:09 +0100, Andrew Gierth wrote:
> > > > So here is my current proposed fix.
> > >
> > > Before pushing a commit that's controversial - and this clearly seems to
> > > somewhat be - it'd be good to give others a heads up that you intend to
> > > do so, so they can object. Rather than just pushing less than 24h later,
> > > without a warning.
> >
> > Seems like that would have meant a potentially very late commit to avoid
> > having a broken (for some value of broken anyway) point release (either
> > with new code, or with reverting the timezone changes previously
> > committed), which isn't great either.
>
> > In general, I agree with you, and we should try to give everyone time to
> > discuss when something is controversial, but this seems like it was at
> > least a bit of a tough call.
>
> Hm? All I'm saying is that Andrew's email should have included something
> to the effect of "Due to the upcoming release, I'm intending to push and
> backpatch the attached fix in ~20h".
Ah, ok, I agree that would have been good to do. Of course, hindsight
being 20/20 and all that. Something to keep in mind for the future
though.
Thanks,
Stephen
Attachments:
signature.asc (application/pgp-signature, 818B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: sfrost@snowman.net, andres@anarazel.de, andrew@tao11.riddles.org.uk, tgl@sss.pgh.pa.us, myon@debian.org, pgsql-hackers@postgresql.org
Subject: Re: UCT (Re: pgsql: Update time zone data files to tzdata release 2019a.)
In-Reply-To: <20190617184053.GI2480@tamriel.snowman.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox