From: Michael Paquier <michael@paquier.xyz>
To: Stephen Frost <sfrost@snowman.net>
Cc: Christoph Berg <myon@debian.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Remove pqsignal() from libpq's official exports list.
Date: Thu, 10 Oct 2019 12:56:35 +0900
Message-ID: <20191010035635.GD1852@paquier.xyz> (raw)
In-Reply-To: <20191009133734.GW6962@tamriel.snowman.net>
References: <E1g5vmT-0003K1-6S@gemulon.postgresql.org>
<20191004095630.GA29119@msg.df7cb.de>
<9333.1570566305@sss.pgh.pa.us>
<20191009073354.GB30556@msg.df7cb.de>
<20191009133734.GW6962@tamriel.snowman.net>
On Wed, Oct 09, 2019 at 09:37:34AM -0400, Stephen Frost wrote:
> Yes, this is absolutely the right answer, we shouldn't be removing
> symbols without an SONAME bump. If we don't want to bump the SONAME,
> then don't remove the symbol. This is utterly basic proper library
> maintenance and it isn't appropriate to argue that it's about "well,
> your old apps shouldn't exist" because it's blatently our fault for not
> bumping the SONAME, no matter how old the apps are.
+1. If we were to bump the SONAME, more cleanup could be actually
done, and I got some pushback not long ago regarding some undocumented
APIs in libpq that we still ship for the exact same reasons:
https://www.postgresql.org/message-id/7990.1565550764@sss.pgh.pa.us
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, sfrost@snowman.net, myon@debian.org, tgl@sss.pgh.pa.us, pgsql-hackers@postgresql.org
Subject: Re: pgsql: Remove pqsignal() from libpq's official exports list.
In-Reply-To: <20191010035635.GD1852@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox