From: Michael Paquier <michael@paquier.xyz>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Amit Kapila <akapila@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Make the order of the header file includes consistent in non-bac
Date: Fri, 25 Oct 2019 15:17:09 +0900
Message-ID: <20191025061709.GE8671@paquier.xyz> (raw)
In-Reply-To: <CAA4eK1+Rvft5SgGnBfGdNCVMspDMiXEo=i7Ue2e9Pm0bbOC3jA@mail.gmail.com>
References: <E1iNpHW-000855-1u@gemulon.postgresql.org>
<20191025031702.GD8671@paquier.xyz>
<CAA4eK1JfDfKvjSYOoQFHu=sSzaqdDTR+JZkZqJkvVnueFJPG5g@mail.gmail.com>
<CAA4eK1+Rvft5SgGnBfGdNCVMspDMiXEo=i7Ue2e9Pm0bbOC3jA@mail.gmail.com>
On Fri, Oct 25, 2019 at 09:32:29AM +0530, Amit Kapila wrote:
> One possible reason could be that pgtypeslib_extern.h has define like below:
> #ifndef bool
> #define bool char
> #endif /* ndef bool */
Possible. I have not looked closely.
> It is possible that all the functions that have bool has a parameter
> in dt_common.c treat it as 'char' where as the declaration of same
> functions in dt.h doesn't consider bool as char because now
> pgtypeslib_extern.h is included after dt.h. It seems that the
> platforms where it failed doesn't have bool defined. What do you
> think? I think we can revert the change in that file.
>
> BTW, prairiedog is also show similar failure and both seems to have
> similar OS except for versions.
Remembering the recent efforts that went behind stdbool.h (see
9a95a77), I think that we should be able to cleanup this header more.
Reverting partially the change looks better for now to put that the
buildfarm back to green.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, amit.kapila16@gmail.com, akapila@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Make the order of the header file includes consistent in non-bac
In-Reply-To: <20191025061709.GE8671@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox