From: Michael Paquier <michael@paquier.xyz>
To: David Steele <david@pgmasters.net>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h
Date: Fri, 6 Mar 2020 08:30:14 +0900
Message-ID: <20200305233014.GA2501@paquier.xyz> (raw)
In-Reply-To: <1cf30561-7dad-dc6e-9fc3-5c456948cfeb@pgmasters.net>
References: <E1j9ioh-0005Kn-4O@gemulon.postgresql.org>
<1cf30561-7dad-dc6e-9fc3-5c456948cfeb@pgmasters.net>
On Thu, Mar 05, 2020 at 12:51:50PM -0500, David Steele wrote:
> Looks like you changed 65535 -> 65536 before commit. I checked the original
> patch and it has 65535.
That's my fault, thanks. I have been playing with the surroundings
while looking at your patch.
> Bit of a bummer that this passed make check-world, but the pgBackRest tests
> definitely did not like it.
Is that because you have a copy of this routine in your code?
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../20200305233014.GA2501@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, david@pgmasters.net, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h
In-Reply-To: <20200305233014.GA2501@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox