pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: doc: clarify where to find pg_type_d.h (PG 11+) and pg_type.h
10+ messages / 2 participants
[nested] [flat]
Commits from this thread:
2020-11-16 0adbd3efb6 5491d7829e 524712ceae 4dccb5c59f 3da1110b8d 8ad06bcbe1 f75a7bb6c2 doc: clarify how to find pg_type_d.h in the install tree
* pgsql: doc: clarify where to find pg_type_d.h (PG 11+) and pg_type.h
@ 2020-11-12 20:13 Bruce Momjian <bruce@momjian.us>
2020-11-12 20:29 ` Re: pgsql: doc: clarify where to find pg_type_d.h (PG 11+) and pg_type.h Alvaro Herrera <alvherre@alvh.no-ip.org>
0 siblings, 1 reply; 10+ messages in thread
From: Bruce Momjian @ 2020-11-12 20:13 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
doc: clarify where to find pg_type_d.h (PG 11+) and pg_type.h
These files are in compiled directories and install directories.
Reported-by: e.indrupskaya@postgrespro.ru
Discussion: https://postgr.es/m/160379609706.24746.7506163279454026608@wrigleys.postgresql.org
Backpatch-through: 9.5
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/152ed04799e31e9abe6c2ed8afc7405b892b7d86
Modified Files
--------------
doc/src/sgml/libpq.sgml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: pgsql: doc: clarify where to find pg_type_d.h (PG 11+) and pg_type.h
2020-11-12 20:13 pgsql: doc: clarify where to find pg_type_d.h (PG 11+) and pg_type.h Bruce Momjian <bruce@momjian.us>
@ 2020-11-12 20:29 ` Alvaro Herrera <alvherre@alvh.no-ip.org>
2020-11-12 23:15 ` Re: pgsql: doc: clarify where to find pg_type_d.h (PG 11+) and pg_type.h Bruce Momjian <bruce@momjian.us>
0 siblings, 1 reply; 10+ messages in thread
From: Alvaro Herrera @ 2020-11-12 20:29 UTC (permalink / raw)
To: Bruce Momjian <bruce@momjian.us>; +Cc: pgsql-committers@lists.postgresql.org
On 2020-Nov-12, Bruce Momjian wrote:
> doc: clarify where to find pg_type_d.h (PG 11+) and pg_type.h
>
> These files are in compiled directories and install directories.
I think this patch is wrong, because in the install tree the files are in
the server/ subdir. It should read:
The <acronym>OID</acronym>s of the built-in data types are defined in
the file <filename>include/catalog/pg_type_d.h</filename> in the
compiled source directory, and in
<filename>include/server/catalog/pg_type_d.h</filename> in the install
directory.
That said, if the user is doing a VPATH build, then "compiled source
directory" is a confusing way to say "the build directory", and I don't
think it's an important location anyway, first because it's really a
throwaway directory, and second it's not even there in a packaged
installation; users just care about the *installed* file, don't they?
So I suggest to rip that part out, and leave just:
The <acronym>OID</acronym>s of the built-in data types are defined in
the file <filename>include/server/catalog/pg_type_d.h</filename> in the
install directory.
^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: pgsql: doc: clarify where to find pg_type_d.h (PG 11+) and pg_type.h
2020-11-12 20:13 pgsql: doc: clarify where to find pg_type_d.h (PG 11+) and pg_type.h Bruce Momjian <bruce@momjian.us>
2020-11-12 20:29 ` Re: pgsql: doc: clarify where to find pg_type_d.h (PG 11+) and pg_type.h Alvaro Herrera <alvherre@alvh.no-ip.org>
@ 2020-11-12 23:15 ` Bruce Momjian <bruce@momjian.us>
2020-11-16 17:36 ` Re: pgsql: doc: clarify where to find pg_type_d.h (PG 11+) and pg_type.h Bruce Momjian <bruce@momjian.us>
0 siblings, 1 reply; 10+ messages in thread
From: Bruce Momjian @ 2020-11-12 23:15 UTC (permalink / raw)
To: Alvaro Herrera <alvherre@alvh.no-ip.org>; +Cc: pgsql-committers@lists.postgresql.org
On Thu, Nov 12, 2020 at 05:29:00PM -0300, Álvaro Herrera wrote:
> On 2020-Nov-12, Bruce Momjian wrote:
>
> > doc: clarify where to find pg_type_d.h (PG 11+) and pg_type.h
> >
> > These files are in compiled directories and install directories.
>
> I think this patch is wrong, because in the install tree the files are in
> the server/ subdir. It should read:
>
> The <acronym>OID</acronym>s of the built-in data types are defined in
> the file <filename>include/catalog/pg_type_d.h</filename> in the
> compiled source directory, and in
> <filename>include/server/catalog/pg_type_d.h</filename> in the install
> directory.
>
> That said, if the user is doing a VPATH build, then "compiled source
> directory" is a confusing way to say "the build directory", and I don't
> think it's an important location anyway, first because it's really a
> throwaway directory, and second it's not even there in a packaged
> installation; users just care about the *installed* file, don't they?
> So I suggest to rip that part out, and leave just:
>
> The <acronym>OID</acronym>s of the built-in data types are defined in
> the file <filename>include/server/catalog/pg_type_d.h</filename> in the
> install directory.
OK, how is this followup patch?
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
Attachments:
pg_type-v2.diff (text/x-diff, 721B) download
diff --git a/doc/src/sgml/libpq.sgml b/doc/src/sgml/libpq.sgml
index 73c6a6ea4d..9d4b6ab4a8 100644
--- a/doc/src/sgml/libpq.sgml
+++ b/doc/src/sgml/libpq.sgml
@@ -3666,8 +3666,8 @@ Oid PQftype(const PGresult *res,
You can query the system table <literal>pg_type</literal> to
obtain the names and properties of the various data types. The
<acronym>OID</acronym>s of the built-in data types are defined
- in the file <filename>include/catalog/pg_type_d.h</filename>
- in the compiled source directory and install directory.
+ in the file <filename>include/server/catalog/pg_type_d.h</filename>
+ in the install directory.
</para>
</listitem>
</varlistentry>
* Re: pgsql: doc: clarify where to find pg_type_d.h (PG 11+) and pg_type.h
2020-11-12 20:13 pgsql: doc: clarify where to find pg_type_d.h (PG 11+) and pg_type.h Bruce Momjian <bruce@momjian.us>
2020-11-12 20:29 ` Re: pgsql: doc: clarify where to find pg_type_d.h (PG 11+) and pg_type.h Alvaro Herrera <alvherre@alvh.no-ip.org>
2020-11-12 23:15 ` Re: pgsql: doc: clarify where to find pg_type_d.h (PG 11+) and pg_type.h Bruce Momjian <bruce@momjian.us>
@ 2020-11-16 17:36 ` Bruce Momjian <bruce@momjian.us>
0 siblings, 0 replies; 10+ messages in thread
From: Bruce Momjian @ 2020-11-16 17:36 UTC (permalink / raw)
To: Alvaro Herrera <alvherre@alvh.no-ip.org>; +Cc: pgsql-committers@lists.postgresql.org
On Thu, Nov 12, 2020 at 06:15:51PM -0500, Bruce Momjian wrote:
> On Thu, Nov 12, 2020 at 05:29:00PM -0300, Álvaro Herrera wrote:
> > On 2020-Nov-12, Bruce Momjian wrote:
> >
> > > doc: clarify where to find pg_type_d.h (PG 11+) and pg_type.h
> > >
> > > These files are in compiled directories and install directories.
> >
> > I think this patch is wrong, because in the install tree the files are in
> > the server/ subdir. It should read:
> >
> > The <acronym>OID</acronym>s of the built-in data types are defined in
> > the file <filename>include/catalog/pg_type_d.h</filename> in the
> > compiled source directory, and in
> > <filename>include/server/catalog/pg_type_d.h</filename> in the install
> > directory.
> >
> > That said, if the user is doing a VPATH build, then "compiled source
> > directory" is a confusing way to say "the build directory", and I don't
> > think it's an important location anyway, first because it's really a
> > throwaway directory, and second it's not even there in a packaged
> > installation; users just care about the *installed* file, don't they?
> > So I suggest to rip that part out, and leave just:
> >
> > The <acronym>OID</acronym>s of the built-in data types are defined in
> > the file <filename>include/server/catalog/pg_type_d.h</filename> in the
> > install directory.
>
> OK, how is this followup patch?
Applied to all branches, thanks.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
^ permalink raw reply [nested|flat] 10+ messages in thread
* pgsql: doc: clarify where to find pg_type_d.h (PG 11+) and pg_type.h
@ 2020-11-12 20:13 Bruce Momjian <bruce@momjian.us>
0 siblings, 0 replies; 10+ messages in thread
From: Bruce Momjian @ 2020-11-12 20:13 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
doc: clarify where to find pg_type_d.h (PG 11+) and pg_type.h
These files are in compiled directories and install directories.
Reported-by: e.indrupskaya@postgrespro.ru
Discussion: https://postgr.es/m/160379609706.24746.7506163279454026608@wrigleys.postgresql.org
Backpatch-through: 9.5
Branch
------
REL_13_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/3f93b3431f8b9539eb2147f29029de50d3d43ec7
Modified Files
--------------
doc/src/sgml/libpq.sgml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 10+ messages in thread
* pgsql: doc: clarify where to find pg_type_d.h (PG 11+) and pg_type.h
@ 2020-11-12 20:13 Bruce Momjian <bruce@momjian.us>
0 siblings, 0 replies; 10+ messages in thread
From: Bruce Momjian @ 2020-11-12 20:13 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
doc: clarify where to find pg_type_d.h (PG 11+) and pg_type.h
These files are in compiled directories and install directories.
Reported-by: e.indrupskaya@postgrespro.ru
Discussion: https://postgr.es/m/160379609706.24746.7506163279454026608@wrigleys.postgresql.org
Backpatch-through: 9.5
Branch
------
REL_12_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/36051198dfa75c9b7e19ae59e458c12f48d67abf
Modified Files
--------------
doc/src/sgml/libpq.sgml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 10+ messages in thread
* pgsql: doc: clarify where to find pg_type_d.h (PG 11+) and pg_type.h
@ 2020-11-12 20:13 Bruce Momjian <bruce@momjian.us>
0 siblings, 0 replies; 10+ messages in thread
From: Bruce Momjian @ 2020-11-12 20:13 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
doc: clarify where to find pg_type_d.h (PG 11+) and pg_type.h
These files are in compiled directories and install directories.
Reported-by: e.indrupskaya@postgrespro.ru
Discussion: https://postgr.es/m/160379609706.24746.7506163279454026608@wrigleys.postgresql.org
Backpatch-through: 9.5
Branch
------
REL_11_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/e60f4a3fc045790d91b4aacab31b37489b697f0a
Modified Files
--------------
doc/src/sgml/libpq.sgml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 10+ messages in thread
* pgsql: doc: clarify where to find pg_type_d.h (PG 11+) and pg_type.h
@ 2020-11-12 20:13 Bruce Momjian <bruce@momjian.us>
0 siblings, 0 replies; 10+ messages in thread
From: Bruce Momjian @ 2020-11-12 20:13 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
doc: clarify where to find pg_type_d.h (PG 11+) and pg_type.h
These files are in compiled directories and install directories.
Reported-by: e.indrupskaya@postgrespro.ru
Discussion: https://postgr.es/m/160379609706.24746.7506163279454026608@wrigleys.postgresql.org
Backpatch-through: 9.5
Branch
------
REL_10_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/658577038ff98ced2f37665d862ad6a70ad2d85c
Modified Files
--------------
doc/src/sgml/libpq.sgml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 10+ messages in thread
* pgsql: doc: clarify where to find pg_type_d.h (PG 11+) and pg_type.h
@ 2020-11-12 20:13 Bruce Momjian <bruce@momjian.us>
0 siblings, 0 replies; 10+ messages in thread
From: Bruce Momjian @ 2020-11-12 20:13 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
doc: clarify where to find pg_type_d.h (PG 11+) and pg_type.h
These files are in compiled directories and install directories.
Reported-by: e.indrupskaya@postgrespro.ru
Discussion: https://postgr.es/m/160379609706.24746.7506163279454026608@wrigleys.postgresql.org
Backpatch-through: 9.5
Branch
------
REL9_6_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/fe709f3e0f178fc2d79fb8d4a16ce88497b702c9
Modified Files
--------------
doc/src/sgml/libpq.sgml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 10+ messages in thread
* pgsql: doc: clarify where to find pg_type_d.h (PG 11+) and pg_type.h
@ 2020-11-12 20:13 Bruce Momjian <bruce@momjian.us>
0 siblings, 0 replies; 10+ messages in thread
From: Bruce Momjian @ 2020-11-12 20:13 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
doc: clarify where to find pg_type_d.h (PG 11+) and pg_type.h
These files are in compiled directories and install directories.
Reported-by: e.indrupskaya@postgrespro.ru
Discussion: https://postgr.es/m/160379609706.24746.7506163279454026608@wrigleys.postgresql.org
Backpatch-through: 9.5
Branch
------
REL9_5_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/be83aeba840a5dc678781151c0560ca9de08d7b3
Modified Files
--------------
doc/src/sgml/libpq.sgml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 10+ messages in thread
end of thread, other threads:[~2020-11-16 17:36 UTC | newest]
Thread overview: 10+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2020-11-12 20:13 pgsql: doc: clarify where to find pg_type_d.h (PG 11+) and pg_type.h Bruce Momjian <bruce@momjian.us>
2020-11-12 20:29 ` Alvaro Herrera <alvherre@alvh.no-ip.org>
2020-11-12 23:15 ` Bruce Momjian <bruce@momjian.us>
2020-11-16 17:36 ` Bruce Momjian <bruce@momjian.us>
2020-11-12 20:13 pgsql: doc: clarify where to find pg_type_d.h (PG 11+) and pg_type.h Bruce Momjian <bruce@momjian.us>
2020-11-12 20:13 pgsql: doc: clarify where to find pg_type_d.h (PG 11+) and pg_type.h Bruce Momjian <bruce@momjian.us>
2020-11-12 20:13 pgsql: doc: clarify where to find pg_type_d.h (PG 11+) and pg_type.h Bruce Momjian <bruce@momjian.us>
2020-11-12 20:13 pgsql: doc: clarify where to find pg_type_d.h (PG 11+) and pg_type.h Bruce Momjian <bruce@momjian.us>
2020-11-12 20:13 pgsql: doc: clarify where to find pg_type_d.h (PG 11+) and pg_type.h Bruce Momjian <bruce@momjian.us>
2020-11-12 20:13 pgsql: doc: clarify where to find pg_type_d.h (PG 11+) and pg_type.h Bruce Momjian <bruce@momjian.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox