pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Stephen Frost <sfrost@snowman.net>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Deduplicate choice of horizon for a relation procarray.c.
Date: Fri, 27 Aug 2021 18:46:39 -0400
Message-ID: <20210827224639.GX17906@tamriel.snowman.net> (raw)
In-Reply-To: <E1m7UuE-0007Gm-9e@gemulon.postgresql.org> <E1m7UuB-0007GK-3Y@gemulon.postgresql.org>

Greetings,

* Andres Freund (andres@anarazel.de) wrote:
> As the code in question was only introduced in dc7420c2c92 it seems worth
> backpatching this change as well, otherwise 14 will look different from all
> other branches.

Interestingly, these patches ended up actually introducing a difference
between 14 and master in the form of:

GlobalVisTestFor(Relation rel)

-   GlobalVisState *state;
+   GlobalVisState *state = NULL;

being done on master but not in the 14 stable branch, leading to, at
least for me:

.../src/backend/storage/ipc/procarray.c: In function ‘GlobalVisTestFor’:
.../src/backend/storage/ipc/procarray.c:4054:9: warning: ‘state’ may be used uninitialized in this function [-Wmaybe-uninitialized]
 4054 |  return state;
      |         ^~~~~

Seems like we should include that change in 14 too, to get rid of the
above warning and to make that bit of code the same too..?

Thanks!

Stephen

Attachments:

  signature.asc (application/pgp-signature, 818B) download

view thread (4+ messages)  latest in thread

Message-ID: <20210827224639.GX17906@tamriel.snowman.net>
Permalink:  ../20210827224639.GX17906@tamriel.snowman.net/
Also on:    postgresql.org/message-id/20210827224639.GX17906@tamriel.snowman.net

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: sfrost@snowman.net, andres@anarazel.de, pgsql-hackers@lists.postgresql.org
  Subject: Re: pgsql: Deduplicate choice of horizon for a relation procarray.c.
  In-Reply-To: <20210827224639.GX17906@tamriel.snowman.net>
  References: <20210827224639.GX17906@tamriel.snowman.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox