From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Cc: Craig Ringer <craig.ringer@enterprisedb.com>
Cc: Noah Misch <noah@leadboat.com>
Subject: Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3.
Date: Thu, 7 Oct 2021 19:39:17 -0300
Message-ID: <202110072239.qh4b5yzcdoy5@alvherre.pgsql> (raw)
In-Reply-To: <179777.1633643325@sss.pgh.pa.us>
On 2021-Oct-07, Tom Lane wrote:
> +Portability
> +-----------
> +
> +Avoid using any bleeding-edge Perl features. We have buildfarm animals
> +running Perl versions as old as 5.8.3, so your tests will be expected
> +to pass on that.
> +
> +Also, do not use any non-core Perl modules except IPC::Run. Or, if you
> +must do so for a particular test, arrange to skip the test when the needed
> +module isn't present. If unsure, you can consult Module::CoreList to find
> +out whether a given module is part of the Perl core, and which module
> +versions shipped with which Perl releases.
LGTM, thanks.
--
Álvaro Herrera Valdivia, Chile — https://www.EnterpriseDB.com/
"Find a bug in a program, and fix it, and the program will work today.
Show the program how to find and fix a bug, and the program
will work forever" (Oliver Silfridge)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: alvherre@alvh.no-ip.org, tgl@sss.pgh.pa.us, daniel@yesql.se, pgsql-hackers@lists.postgresql.org, craig.ringer@enterprisedb.com, noah@leadboat.com
Subject: Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3.
In-Reply-To: <202110072239.qh4b5yzcdoy5@alvherre.pgsql>
References: <179777.1633643325@sss.pgh.pa.us> <202110072239.qh4b5yzcdoy5@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox