pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Noah Misch <noah@leadboat.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Require version 0.98 of Test::More for TAP tests
Date: Sat, 20 Nov 2021 17:37:15 -0800
Message-ID: <20211121013715.GC1362012@rfd.leadboat.com> (raw)
In-Reply-To: <3386968.1637457734@sss.pgh.pa.us>
References: <E1moZHS-0002Cu-Ei@gemulon.postgresql.org>
	<3369543.1637454364@sss.pgh.pa.us>
	<3369927.1637454743@sss.pgh.pa.us>
	<20211121003630.GA1362012@rfd.leadboat.com>
	<3371085.1637455802@sss.pgh.pa.us>
	<20211121011026.GB1362012@rfd.leadboat.com>
	<3386968.1637457734@sss.pgh.pa.us>

On Sat, Nov 20, 2021 at 08:22:14PM -0500, Tom Lane wrote:
> Noah Misch <noah@leadboat.com> writes:
> > On Sat, Nov 20, 2021 at 07:50:02PM -0500, Tom Lane wrote:
> >> What I'm inclined to do is temporarily push `dirname $PERL` onto the front
> >> of PATH while running
> >> PGAC_PATH_PROGS(PROVE, prove)
> 
> > Adding to PATH, even briefly, is way too brazen.  You'd need to be sure that
> > PATH is never searched for anything other than "prove", which is hard to
> > ensure in a shell script.
> 
> Hmm.  I kind of doubt that anyone would be selecting a perl in an
> untrustworthy directory --- wouldn't that imply that $blackhat could
> overwrite perl itself?

Typically, but: sticky bit, NFS ACLs, only-formerly-writable directory, etc.

> > I'd be -1 on a back-patch and -0.7 for HEAD.
> 
> I think we need a back-patch of *something*.  It's pure luck that wrasse
> hasn't shown problems already.  I don't want to be rediscovering this
> issue a year from now when somebody back-patches some test requiring
> subtests.

If you want to allow subtests in all branches, $SUBJECT is the thing needing a
back-patch.  By default, they remain banned in back-patches.  Personally, I've
just added a check to my script for converting v15 TAP tests to v14 TAP tests:

#! /bin/sh
# This translates a PostgreSQL 15 TAP test into a PostgreSQL 14 TAP test
sed -i '
  s/PostgreSQL::Test::Cluster/PostgresNode/g
  s/PostgreSQL::Test::Utils/TestLib/g
  s/PostgresNode->new/get_new_node/g
' -- "$@"
grep -w subtest -- "$@"





view thread (17+ messages)  latest in thread

Message-ID: <20211121013715.GC1362012@rfd.leadboat.com>
Permalink:  ../20211121013715.GC1362012@rfd.leadboat.com/
Also on:    postgresql.org/message-id/20211121013715.GC1362012@rfd.leadboat.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: noah@leadboat.com, tgl@sss.pgh.pa.us, andrew@dunslane.net, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Require version 0.98 of Test::More for TAP tests
  In-Reply-To: <20211121013715.GC1362012@rfd.leadboat.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox