From: Justin Pryzby <pryzby@telsasoft.com>
To: Robert Haas <rhaas@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: pg_basebackup: Fix a couple of recently-introduced bugs.
Date: Thu, 27 Jan 2022 11:45:45 -0600
Message-ID: <20220127174545.GV23027@telsasoft.com> (raw)
In-Reply-To: <E1nD7R3-0002XT-SL@gemulon.postgresql.org>
References: <E1nD7R3-0002XT-SL@gemulon.postgresql.org>
On Thu, Jan 27, 2022 at 04:15:45PM +0000, Robert Haas wrote:
> pg_basebackup: Fix a couple of recently-introduced bugs.
>
> The server expects the compression level to be between 1 and 9, but
> Z_DEFAULT_COMPRESSION is -1, so we must not try to send that value
> to the server.
If I'm not wrong, this is causing failures on cfbot.
https://cirrus-ci.com/task/6312181619752960?logs=build#L2056
[17:24:48.348] c:\cirrus\src\backend\replication\basebackup_gzip.c(90): warning C4715: 'bbsink_gzip_new': not all control paths return a value [c:\cirrus\postgres.vcxproj]
[17:24:48.348] c:\cirrus\src\bin\pg_basebackup\pg_basebackup.c(1922,67): error C2065: 'Z_DEFAULT_COMPRESSION': undeclared identifier [c:\cirrus\pg_basebackup.vcxproj]
The warning seems to be what's fixed by David's patch here.
https://www.postgresql.org/message-id/CA%2BTgmobSeRFM84pwa5HfZCGRx%3DQ-iFfPFZfq-4%3Dt1p04yxg_Og%40ma...
--
Justin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: pryzby@telsasoft.com, rhaas@postgresql.org
Subject: Re: pgsql: pg_basebackup: Fix a couple of recently-introduced bugs.
In-Reply-To: <20220127174545.GV23027@telsasoft.com>
References: <E1nD7R3-0002XT-SL@gemulon.postgresql.org> <20220127174545.GV23027@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox