pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
To: andres@anarazel.de
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai
Date: Mon, 31 Jan 2022 17:35:16 +0900 (JST)
Message-ID: <20220131.173516.954037459158462050.horikyota.ntt@gmail.com> (raw)
In-Reply-To: <20220131013548.enc5d6qqyokhmj3q@alap3.anarazel.de>
References: <E1nEKoB-0007Fc-HF@gemulon.postgresql.org>
	<20220131013548.enc5d6qqyokhmj3q@alap3.anarazel.de>

At Sun, 30 Jan 2022 17:35:48 -0800, Andres Freund <andres@anarazel.de> wrote in 
> Hi,
> 
> On 2022-01-31 00:44:39 +0000, Andres Freund wrote:
> > plperl: windows: Use Perl_setlocale on 5.28+, fixing compile failure.
> > 
> > For older versions we need our own copy of perl's setlocale(), because it was
> > not exposed (why we need the setlocale in the first place is explained in
> > plperl_init_interp) . The copy stopped working in 5.28, as some of the used
> > macros are not public anymore.  But Perl_setlocale is available in 5.28, so
> > use that.
> > 
> > Author: Victor Wagner <vitus@wagner.pp.ru>
> > Reviewed-By: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
> > Discussion: https://postgr.es/m/20200501134711.08750c5f@antares.wagner.home
> > Backpatch: all versions
> > 
> > Branch
> > ------
> > REL_14_STABLE
> 
> I see this broke on everywhere but master. Looking.

Anyways, I can build on windows with this (even only on
master). Thanks for the work!

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center





view thread (14+ messages)  latest in thread

Message-ID: <20220131.173516.954037459158462050.horikyota.ntt@gmail.com>
Permalink:  ../20220131.173516.954037459158462050.horikyota.ntt@gmail.com/
Also on:    postgresql.org/message-id/20220131.173516.954037459158462050.horikyota.ntt@gmail.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: horikyota.ntt@gmail.com, andres@anarazel.de
  Subject: Re: pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai
  In-Reply-To: <20220131.173516.954037459158462050.horikyota.ntt@gmail.com>
  References: <E1nEKoB-0007Fc-HF@gemulon.postgresql.org> <20220131013548.enc5d6qqyokhmj3q@alap3.anarazel.de> <20220131.173516.954037459158462050.horikyota.ntt@gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox