pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-committers@lists.postgresql.org, Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Subject: Re: pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai
Date: Tue, 01 Feb 2022 22:07:53 -0500
Message-ID: <1052579.1643771273@sss.pgh.pa.us> (raw)
In-Reply-To: <20220131203125.xg2cz33g2xenayy5@alap3.anarazel.de>
References: <E1nEKoB-0007Fc-HF@gemulon.postgresql.org>
	<20220131013548.enc5d6qqyokhmj3q@alap3.anarazel.de>
	<20220131015130.shn6wr2fzuymerf6@alap3.anarazel.de>
	<535668.1643594467@sss.pgh.pa.us>
	<20220131020934.g6bfyalgkwnvqugw@alap3.anarazel.de>
	<829537.1643659710@sss.pgh.pa.us>
	<20220131203125.xg2cz33g2xenayy5@alap3.anarazel.de>

Andres Freund <andres@anarazel.de> writes:
> On 2022-01-31 15:08:30 -0500, Tom Lane wrote:
>> Done now.

> Thanks!

Just for the archives' sake --- seems this broke pademelon [1]:

cc -Ae -g +O0 -Wp,-H16384 +Z -I. -I. -I../../../src/include  -D_XOPEN_SOURCE_EXTENDED  -I/usr/local/libxml2-2.6.23/include/libxml2 -I/usr/local/include -DDEBUGGING  -I/opt/perl5.8.9/lib/5.8.9/PA-RISC2.0-multi/CORE  -c -o plperl.o plperl.c
...
cc: "plperl.c", line 669: error 1000: Unexpected symbol: "do".
cc: "plperl.c", line 669: error 1000: Unexpected symbol: "_sv".
cc: error 2017: Cannot recover from earlier errors, terminating.
make[3]: *** [plperl.o] Error 1

I've not tried to trace that in detail, but it seems clear that
something in the newer ppport.h is assuming a C99-compliant
compiler.  I can hardly blame the Perl guys for assuming that
in 2022, so I'm just going to remove --with-perl from that
animal.

(It appears that Python 3 assumes C99-compliance too, in
a different way [2], so I've also had to remove --with-python.
Maybe I could resurrect that if I built Python 2.7 on that
machine, but I don't think I'm going to summon the motivation.
The world has clearly Moved On from pre-C99 compilers.)

			regards, tom lane

[1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=pademelon&dt=2022-02-02%2000%3A47%3A30
[2] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=pademelon&dt=2022-02-02%2000%3A21%3A18





view thread (14+ messages)

Message-ID: <1052579.1643771273@sss.pgh.pa.us>
Permalink:  ../1052579.1643771273@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1052579.1643771273@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, ilmari@ilmari.org
  Subject: Re: pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai
  In-Reply-To: <1052579.1643771273@sss.pgh.pa.us>
  References: <E1nEKoB-0007Fc-HF@gemulon.postgresql.org> <20220131013548.enc5d6qqyokhmj3q@alap3.anarazel.de> <20220131015130.shn6wr2fzuymerf6@alap3.anarazel.de> <535668.1643594467@sss.pgh.pa.us> <20220131020934.g6bfyalgkwnvqugw@alap3.anarazel.de> <829537.1643659710@sss.pgh.pa.us> <20220131203125.xg2cz33g2xenayy5@alap3.anarazel.de> <1052579.1643771273@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox