pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org
Cc: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Subject: Re: pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai
Date: Sun, 30 Jan 2022 17:51:30 -0800
Message-ID: <20220131015130.shn6wr2fzuymerf6@alap3.anarazel.de> (raw)
In-Reply-To: <20220131013548.enc5d6qqyokhmj3q@alap3.anarazel.de>
References: <E1nEKoB-0007Fc-HF@gemulon.postgresql.org>
	<20220131013548.enc5d6qqyokhmj3q@alap3.anarazel.de>

Hi,

On 2022-01-30 17:35:48 -0800, Andres Freund wrote:
> I see this broke on everywhere but master. Looking.

Ugh. It's that we didn't backport pport.h.

commit 05798c9f7f08908bdd06c82d934da67535b72005
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date:   2021-10-07 13:59:43 -0400

    plperl: update ppport.h to Perl 5.34.0.

    Also apply the changes suggested by running
        perl ppport.h --compat-version=5.8.0

    And remove some no-longer-required NEED_foo declarations.

    Dagfinn Ilmari Mannsåker

    Discussion: https://postgr.es/m/87y278s6iq.fsf@wibble.ilmari.org


I didn't see that locally (linux) on the backbranches earlier
because I had the
#if defined(WIN32) && PERL_VERSION_LT(5, 28, 0)
split over two ifdefs. And only merged it in a last bit of cleanup :(

Unless somebody comes up with a better idea quickly I'm going use a plain
PERL_VERSION check in the backbranches. Might also be a good idea to backpatch
the above commit, but that requires more discussion than I want to leave the
buildfarm red for.

Greetings,

Andres Freund





view thread (14+ messages)  latest in thread

Message-ID: <20220131015130.shn6wr2fzuymerf6@alap3.anarazel.de>
Permalink:  ../20220131015130.shn6wr2fzuymerf6@alap3.anarazel.de/
Also on:    postgresql.org/message-id/20220131015130.shn6wr2fzuymerf6@alap3.anarazel.de

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de, ilmari@ilmari.org
  Subject: Re: pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai
  In-Reply-To: <20220131015130.shn6wr2fzuymerf6@alap3.anarazel.de>
  References: <E1nEKoB-0007Fc-HF@gemulon.postgresql.org> <20220131013548.enc5d6qqyokhmj3q@alap3.anarazel.de> <20220131015130.shn6wr2fzuymerf6@alap3.anarazel.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox