pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: pgsql-hackers@postgresql.org, pgsql-release@postgresql.org, Noah Misch <noah@leadboat.com>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Avoid race in RelationBuildDesc() affecting CREATE INDEX CONCURR
Date: Tue, 8 Feb 2022 17:53:59 -0800
Message-ID: <20220209015359.wvstb5rxzj53zrtp@alap3.anarazel.de> (raw)
In-Reply-To: <40d0a4c8-de56-7710-5197-1304fa156aba@enterprisedb.com>
References: <E1meSUe-0004WX-H2@gemulon.postgresql.org>
	<df7b4c0b-7d92-f03f-75c4-9e08b269a716@enterprisedb.com>
	<20220209004347.mnwaoiv5x7dntuvi@alap3.anarazel.de>
	<40d0a4c8-de56-7710-5197-1304fa156aba@enterprisedb.com>

Hi,

On 2022-02-09 02:25:09 +0100, Tomas Vondra wrote:
> AFAICS this only affects builds with CLOBBER_CACHE_ALWAYS, and anyone
> running such build in production clearly likes painful things anyway.

Yea, realistically nobody does that.


> But really, for the infinite loop to happen, building a relation descriptor
> has to invalidate a cache. And I haven't found a way to do that without the
> CLOBBER_CACHE_ALWAYS thing.

Phew.


> Also, all the November minor releases include this commit, and there were no
> reports about this (pretty obvious) issue. Buildfarm did not complain either
> (but an animal may be stuck for months and we would not know about it).

Ah, somehow I thought that wasn't yet in the last set of releases. Phew #2.

Greetings,

Andres Freund





view thread (18+ messages)  latest in thread

Message-ID: <20220209015359.wvstb5rxzj53zrtp@alap3.anarazel.de>
Permalink:  ../20220209015359.wvstb5rxzj53zrtp@alap3.anarazel.de/
Also on:    postgresql.org/message-id/20220209015359.wvstb5rxzj53zrtp@alap3.anarazel.de

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de, tomas.vondra@enterprisedb.com, noah@leadboat.com
  Subject: Re: pgsql: Avoid race in RelationBuildDesc() affecting CREATE INDEX CONCURR
  In-Reply-To: <20220209015359.wvstb5rxzj53zrtp@alap3.anarazel.de>
  References: <E1meSUe-0004WX-H2@gemulon.postgresql.org> <df7b4c0b-7d92-f03f-75c4-9e08b269a716@enterprisedb.com> <20220209004347.mnwaoiv5x7dntuvi@alap3.anarazel.de> <40d0a4c8-de56-7710-5197-1304fa156aba@enterprisedb.com> <20220209015359.wvstb5rxzj53zrtp@alap3.anarazel.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox