pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Christoph Berg <myon@debian.org>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Add TAP test to automate the equivalent of check_guc
Date: Sat, 12 Feb 2022 12:10:46 -0800
Message-ID: <20220212201046.uyc2yootpaguph3o@alap3.anarazel.de> (raw)
In-Reply-To: <Ygc3wmaerpCI5l1u@paquier.xyz>
References: <E1nHbaO-0000MF-RO@gemulon.postgresql.org>
	<YgYw25OXV5men8Fj@msg.df7cb.de>
	<2023925.1644591595@sss.pgh.pa.us>
	<20220211153549.GE31460@telsasoft.com>
	<2027230.1644594087@sss.pgh.pa.us>
	<20220211172929.GF31460@telsasoft.com>
	<2079693.1644600871@sss.pgh.pa.us>
	<YgcEK0bJhchPk/NS@paquier.xyz>
	<Ygc3wmaerpCI5l1u@paquier.xyz>

Hi,

On 2022-02-12 13:29:54 +0900, Michael Paquier wrote:
> On Sat, Feb 12, 2022 at 09:49:47AM +0900, Michael Paquier wrote:
> > I guess that it would be better to revert the TAP test and rework all
> > that for the time being, then.
> 
> And this part is done.

You wrote in the commit message that:

"However, this is also an issue as a TAP test only offers the build directory
as of TESTDIR in the environment context, so this would fail with VPATH
builds."

Tap tests currently are always executed in the source directory above t/, as
far as I can tell. So I don't think VPATH/non-VPATH or windows / non-windows
would break using a relative reference from the test dir.

Greetings,

Andres Freund





view thread (26+ messages)  latest in thread

Message-ID: <20220212201046.uyc2yootpaguph3o@alap3.anarazel.de>
Permalink:  ../20220212201046.uyc2yootpaguph3o@alap3.anarazel.de/
Also on:    postgresql.org/message-id/20220212201046.uyc2yootpaguph3o@alap3.anarazel.de

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de, michael@paquier.xyz, tgl@sss.pgh.pa.us, pryzby@telsasoft.com, myon@debian.org, pgsql-hackers@lists.postgresql.org
  Subject: Re: pgsql: Add TAP test to automate the equivalent of check_guc
  In-Reply-To: <20220212201046.uyc2yootpaguph3o@alap3.anarazel.de>
  References: <E1nHbaO-0000MF-RO@gemulon.postgresql.org> <YgYw25OXV5men8Fj@msg.df7cb.de> <2023925.1644591595@sss.pgh.pa.us> <20220211153549.GE31460@telsasoft.com> <2027230.1644594087@sss.pgh.pa.us> <20220211172929.GF31460@telsasoft.com> <2079693.1644600871@sss.pgh.pa.us> <YgcEK0bJhchPk/NS@paquier.xyz> <Ygc3wmaerpCI5l1u@paquier.xyz> <20220212201046.uyc2yootpaguph3o@alap3.anarazel.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox