pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: Michael Paquier <michael@paquier.xyz>
Cc: Robert Haas <rhaas@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add suport for server-side LZ4 base backup compression.
Date: Sat, 12 Feb 2022 14:06:43 -0800
Message-ID: <20220212220643.ozuvq2k4cjkcnr2v@alap3.anarazel.de> (raw)
In-Reply-To: <Ygc51WVAFGocSu4h@paquier.xyz>
References: <E1nIWNg-0005L1-2v@gemulon.postgresql.org>
	<Ygc51WVAFGocSu4h@paquier.xyz>

Hi,

On 2022-02-12 13:38:45 +0900, Michael Paquier wrote:
> Perhaps you'd better check that 'decompress_program' can be executed
> and skip things if the command is not around?  Note that
> 020_pg_receivewal.pl does an extra lz4 --version as a safety measure,
> but 008_untar.pl does not.

Actually executing the command doesn't seem useful? It doesn't seem useful to
ignore an executable that's not actually executable or such. Testing whether
the file exists makes sense though.

Greetings,

Andres Freund





view thread (13+ messages)  latest in thread

Message-ID: <20220212220643.ozuvq2k4cjkcnr2v@alap3.anarazel.de>
Permalink:  ../20220212220643.ozuvq2k4cjkcnr2v@alap3.anarazel.de/
Also on:    postgresql.org/message-id/20220212220643.ozuvq2k4cjkcnr2v@alap3.anarazel.de

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de, michael@paquier.xyz, rhaas@postgresql.org
  Subject: Re: pgsql: Add suport for server-side LZ4 base backup compression.
  In-Reply-To: <20220212220643.ozuvq2k4cjkcnr2v@alap3.anarazel.de>
  References: <E1nIWNg-0005L1-2v@gemulon.postgresql.org> <Ygc51WVAFGocSu4h@paquier.xyz> <20220212220643.ozuvq2k4cjkcnr2v@alap3.anarazel.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox