pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
To: thomas.munro@gmail.com
Cc: tgl@sss.pgh.pa.us
Cc: david@pgmasters.net
Cc: tmunro@postgresql.org
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix pg_basebackup with in-place tablespaces.
Date: Wed, 16 Mar 2022 14:42:16 +0900 (JST)
Message-ID: <20220316.144216.300331926466543986.horikyota.ntt@gmail.com> (raw)
In-Reply-To: <CA+hUKG+sAx4edyX3290QmjBmKAwKcg1GOam50yqXwiVSMQowzg@mail.gmail.com>
References: <66373991-e520-40c1-f1e8-c758c7b24cb7@pgmasters.net>
	<428075.1647379703@sss.pgh.pa.us>
	<CA+hUKG+sAx4edyX3290QmjBmKAwKcg1GOam50yqXwiVSMQowzg@mail.gmail.com>

At Wed, 16 Mar 2022 11:13:53 +1300, Thomas Munro <thomas.munro@gmail.com> wrote in 
> On Wed, Mar 16, 2022 at 10:28 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > David Steele <david@pgmasters.net> writes:
> > > On 3/14/22 19:31, Thomas Munro wrote:
> > >> Fix pg_basebackup with in-place tablespaces.
> >
> > > Perhaps I'm being picky, but seems like this logic should be wrapped in:
> > > if (allow_in_place_tablespaces)
> > > {
> > >      <...>
> > > }
> > > I worry about strange effects when this GUC is not enabled.
> >
> > What would happen if someone created an in-place tablespace and
> > then turned off the GUC?
> 
> Then it would break with unhelpful error messages.  I suppose we could
> error out explicitly, "in-place tablespace detected, but
> allow_in_place_tablespaces not enabled".  I'm not sure why we should
> suddenly choose to enforce that *here* though.

+1. The GUC is only to prevent non-developer users from accidentally
creating in-place tablespaces that is not officieally suported.  We
have done nothing about in-place tablespaces other than the things
needed to perform regression test, and I think we won't do that in
future.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center





view thread (9+ messages)  latest in thread

Message-ID: <20220316.144216.300331926466543986.horikyota.ntt@gmail.com>
Permalink:  ../20220316.144216.300331926466543986.horikyota.ntt@gmail.com/
Also on:    postgresql.org/message-id/20220316.144216.300331926466543986.horikyota.ntt@gmail.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: horikyota.ntt@gmail.com, thomas.munro@gmail.com, tgl@sss.pgh.pa.us, david@pgmasters.net, tmunro@postgresql.org
  Subject: Re: pgsql: Fix pg_basebackup with in-place tablespaces.
  In-Reply-To: <20220316.144216.300331926466543986.horikyota.ntt@gmail.com>
  References: <66373991-e520-40c1-f1e8-c758c7b24cb7@pgmasters.net> <428075.1647379703@sss.pgh.pa.us> <CA+hUKG+sAx4edyX3290QmjBmKAwKcg1GOam50yqXwiVSMQowzg@mail.gmail.com> <20220316.144216.300331926466543986.horikyota.ntt@gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox