pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Magnus Hagander <magnus@hagander.net>
Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module.
Date: Sat, 26 Mar 2022 12:35:28 -0700
Message-ID: <20220326193528.rabb66n6i7ghhesx@alap3.anarazel.de> (raw)
In-Reply-To: <CA+TgmoYwwTgNPJz34p6MJPAv8OYH77+-sMbae13Ygv8ENfGXdA@mail.gmail.com>
References: <E1nUB2m-000CYD-DY@gemulon.postgresql.org>
	<20220315190428.2xf6klawmaq4nuyy@alap3.anarazel.de>
	<CA+TgmoZZJK7Tx1aG2yTsaOTuCdjQkB0wY9vNCTSqf7tAubtZAQ@mail.gmail.com>
	<CA+TgmoagO0Dofpy8PUyphNXaTovqRCpYOQuP+BKPeSe3kH1zJw@mail.gmail.com>
	<626827E9-4A50-493D-A8EE-EB3C238BB47F@anarazel.de>
	<CA+TgmoZ6DdRe0=YYv-dXfKCpfwaoKdUXP6gXg7qVB=3FwON1GA@mail.gmail.com>
	<7b5c224e-c9c0-fd93-2b51-b399de2d1d4b@dunslane.net>
	<CA+TgmoYwwTgNPJz34p6MJPAv8OYH77+-sMbae13Ygv8ENfGXdA@mail.gmail.com>

Hi,

On 2022-03-26 14:40:06 -0400, Robert Haas wrote:
> Well, I think that's unwarranted. Many years ago, people discovered
> that it was annoying if you had to distinguish files solely based on
> name, and so they invented directories and pathnames. That was a good
> call.

Yea. I have no problem naming tests the same way, particularly if they do
similar things. But we should show the path.


> Displaying that information in the buildfarm output would be a good call,
> too.

I would find it very useful locally when running the tests too. A very simple
approach would be to invoke prove with absolute paths to the tests. But that's
not particularly pretty.  But unless we change the directory that prove is run
in away from the directory that contains t/ (there's a thread about that, but
more to do), I don't think we can do better on an individual test basis?

We could just make prove_[install]check echo the $(subdir) it's about to run
tests for? Certainly looks better to me:

make -j48 -Otarget -s -C src/bin/ check NO_TEMP_INSTALL=1
...
=== tap tests in src/bin/pg_resetwal ===
t/001_basic.pl ...... ok
t/002_corrupted.pl .. ok
All tests successful.
Files=2, Tests=18,  3 wallclock secs ( 0.01 usr  0.01 sys +  2.39 cusr  0.31 csys =  2.72 CPU)
Result: PASS
=== tap tests in src/bin/pg_checksums ===
t/001_basic.pl .... ok
t/002_actions.pl .. ok
All tests successful.
Files=2, Tests=74,  4 wallclock secs ( 0.02 usr  0.01 sys +  1.57 cusr  0.42 csys =  2.02 CPU)
Result: PASS
=== tap tests in src/bin/psql ===
t/001_basic.pl ........... ok
t/010_tab_completion.pl .. ok
t/020_cancel.pl .......... ok
All tests successful.
Files=3, Tests=125,  6 wallclock secs ( 0.03 usr  0.00 sys +  3.65 cusr  0.56 csys =  4.24 CPU)
Result: PASS
...

Greetings,

Andres Freund





view thread (66+ messages)  latest in thread

Message-ID: <20220326193528.rabb66n6i7ghhesx@alap3.anarazel.de>
Permalink:  ../20220326193528.rabb66n6i7ghhesx@alap3.anarazel.de/
Also on:    postgresql.org/message-id/20220326193528.rabb66n6i7ghhesx@alap3.anarazel.de

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de, robertmhaas@gmail.com, andrew@dunslane.net, pgsql-hackers@lists.postgresql.org, magnus@hagander.net
  Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module.
  In-Reply-To: <20220326193528.rabb66n6i7ghhesx@alap3.anarazel.de>
  References: <E1nUB2m-000CYD-DY@gemulon.postgresql.org> <20220315190428.2xf6klawmaq4nuyy@alap3.anarazel.de> <CA+TgmoZZJK7Tx1aG2yTsaOTuCdjQkB0wY9vNCTSqf7tAubtZAQ@mail.gmail.com> <CA+TgmoagO0Dofpy8PUyphNXaTovqRCpYOQuP+BKPeSe3kH1zJw@mail.gmail.com> <626827E9-4A50-493D-A8EE-EB3C238BB47F@anarazel.de> <CA+TgmoZ6DdRe0=YYv-dXfKCpfwaoKdUXP6gXg7qVB=3FwON1GA@mail.gmail.com> <7b5c224e-c9c0-fd93-2b51-b399de2d1d4b@dunslane.net> <CA+TgmoYwwTgNPJz34p6MJPAv8OYH77+-sMbae13Ygv8ENfGXdA@mail.gmail.com> <20220326193528.rabb66n6i7ghhesx@alap3.anarazel.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox