pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Nathan Bossart <nathandbossart@gmail.com>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Magnus Hagander <magnus@hagander.net>
Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module.
Date: Wed, 30 Mar 2022 22:25:00 -0700
Message-ID: <20220331052500.eidoln5dcrhqza7b@alap3.anarazel.de> (raw)
In-Reply-To: <497188.1648699680@sss.pgh.pa.us>
References: <CA+TgmoaZ6L37kVJPRDavbtRa+wq-vtBkd3L9s=B7d91BF-UW4Q@mail.gmail.com>
	<20220330165450.3lruwky7eveddsvq@alap3.anarazel.de>
	<CA+TgmobK9EEyPpVuBs7UL_1wHkgAbFdnAkrFox6h_0-5i7HM2A@mail.gmail.com>
	<285252.1648671723@sss.pgh.pa.us>
	<CA+TgmoYgrjwh8SVPG_hiq1U4=bxj5MaR_RQ+abvO7izm94rEXQ@mail.gmail.com>
	<20220330223531.GA134543@nathanxps13>
	<472639.1648684865@sss.pgh.pa.us>
	<485495.1648692468@sss.pgh.pa.us>
	<20220331021717.xusjlknpbs7szyv6@alap3.anarazel.de>
	<497188.1648699680@sss.pgh.pa.us>

Hi,

On 2022-03-31 00:08:00 -0400, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > I assume SSPI doesn't work over unix sockets? Oh. Maybe it's not even that -
> > we only enable it when not using unix sockets:
> 
> Duh.  But can it work over unix sockets?

I wonder if we should go the other way and use unix sockets by default in the
tests. Even if CI windows could be made to use SSPI, it'd still be further
away from the environment most of us write tests in.

Afaics the only reason we use SSPI is to secure the tests, because they run
over tcp by default. But since we have unix socket support for windows now,
that shouldn't really be needed anymore.

The only animal that might not be new enough for it is hamerkop. I don't
really understand when windows features end up in which release.

Looking at 8f3ec75de40 it seems we just assume unix sockets are available, we
don't have a version / feature test (win32.h just defines
HAVE_STRUCT_SOCKADDR_UN).

Greetings,

Andres Freund





view thread (66+ messages)  latest in thread

Message-ID: <20220331052500.eidoln5dcrhqza7b@alap3.anarazel.de>
Permalink:  ../20220331052500.eidoln5dcrhqza7b@alap3.anarazel.de/
Also on:    postgresql.org/message-id/20220331052500.eidoln5dcrhqza7b@alap3.anarazel.de

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de, tgl@sss.pgh.pa.us, robertmhaas@gmail.com, nathandbossart@gmail.com, andrew@dunslane.net, thomas.munro@gmail.com, pgsql-hackers@lists.postgresql.org, magnus@hagander.net
  Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module.
  In-Reply-To: <20220331052500.eidoln5dcrhqza7b@alap3.anarazel.de>
  References: <CA+TgmoaZ6L37kVJPRDavbtRa+wq-vtBkd3L9s=B7d91BF-UW4Q@mail.gmail.com> <20220330165450.3lruwky7eveddsvq@alap3.anarazel.de> <CA+TgmobK9EEyPpVuBs7UL_1wHkgAbFdnAkrFox6h_0-5i7HM2A@mail.gmail.com> <285252.1648671723@sss.pgh.pa.us> <CA+TgmoYgrjwh8SVPG_hiq1U4=bxj5MaR_RQ+abvO7izm94rEXQ@mail.gmail.com> <20220330223531.GA134543@nathanxps13> <472639.1648684865@sss.pgh.pa.us> <485495.1648692468@sss.pgh.pa.us> <20220331021717.xusjlknpbs7szyv6@alap3.anarazel.de> <497188.1648699680@sss.pgh.pa.us> <20220331052500.eidoln5dcrhqza7b@alap3.anarazel.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox