pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
To: alvherre@alvh.no-ip.org
Cc: robertmhaas@gmail.com
Cc: markus.wanner@enterprisedb.com
Cc: pgsql-hackers@postgresql.org
Subject: Re: API stability
Date: Wed, 06 Apr 2022 18:21:16 +0900 (JST)
Message-ID: <20220406.182116.70086612010355256.horikyota.ntt@gmail.com> (raw)
In-Reply-To: <20220406.181317.2029659158435249356.horikyota.ntt@gmail.com>
References: <20220406.164521.17171257901083417.horikyota.ntt@gmail.com>
	<202204060830.gmkykqfh3b4a@alvherre.pgsql>
	<20220406.181317.2029659158435249356.horikyota.ntt@gmail.com>

At Wed, 06 Apr 2022 18:13:17 +0900 (JST), Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote in 
> At Wed, 6 Apr 2022 10:30:32 +0200, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote in 
> > For code documentation purposes, I think it is slightly better to use
> > bits8 than uint8 for variables where you're storing independent bit flags.
> 
> Oh, agreed.  Will fix in the next version along with other fixes.

The immediately folloing member statusFlags is in uint8.  So using
bits8 here results in the following look.

>	bits8		delayChkptFlags;/* for DELAY_CHKPT_* flags */
>
>	uint8		statusFlags;	/* this backend's status flags, see PROC_*
>								 * above. mirrored in

PGPROC has another member that fits  bits*.

>	uint64		fpLockBits;		/* lock modes held for each fast-path slot */

Do I change this in this patch? Or leave them for another chance?

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center





view thread (14+ messages)  latest in thread

Message-ID: <20220406.182116.70086612010355256.horikyota.ntt@gmail.com>
Permalink:  ../20220406.182116.70086612010355256.horikyota.ntt@gmail.com/
Also on:    postgresql.org/message-id/20220406.182116.70086612010355256.horikyota.ntt@gmail.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: horikyota.ntt@gmail.com, alvherre@alvh.no-ip.org, robertmhaas@gmail.com, markus.wanner@enterprisedb.com, pgsql-hackers@postgresql.org
  Subject: Re: API stability
  In-Reply-To: <20220406.182116.70086612010355256.horikyota.ntt@gmail.com>
  References: <20220406.164521.17171257901083417.horikyota.ntt@gmail.com> <202204060830.gmkykqfh3b4a@alvherre.pgsql> <20220406.181317.2029659158435249356.horikyota.ntt@gmail.com> <20220406.182116.70086612010355256.horikyota.ntt@gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox