From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Melanie Plageman <melanieplageman@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Unstable tests for recovery conflict handling
Date: Wed, 27 Apr 2022 18:31:34 -0700
Message-ID: <20220428013134.gahwtxwfuu6gwfwe@alap3.anarazel.de> (raw)
In-Reply-To: <447238.1651082925@sss.pgh.pa.us>
References: <E1nca5h-000nN0-6f@gemulon.postgresql.org>
<394950.1651077914@sss.pgh.pa.us>
<447238.1651082925@sss.pgh.pa.us>
Hi,
On 2022-04-27 14:08:45 -0400, Tom Lane wrote:
> I wrote:
> > It's been kind of hidden by other buildfarm noise, but
> > 031_recovery_conflict.pl is not as stable as it should be [1][2][3][4].
> > ...
> > I think this is showing us a real bug, ie we sometimes fail to cancel
> > the conflicting query.
>
> After digging around in the code, I think this is almost certainly
> some manifestation of the previously-complained-of problem [1] that
> RecoveryConflictInterrupt is not safe to call in a signal handler,
> leading the conflicting backend to sometimes decide that it's not
> the problem.
I think at least some may actually be because of
https://postgr.es/m/20220409045515.35ypjzddp25v72ou%40alap3.anarazel.de
rather than RecoveryConflictInterrupt itself.
I'll go an finish up the comment bits that I still need to clean up in my
bugix and commit that...
Greetings,
Andres Freund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: andres@anarazel.de, tgl@sss.pgh.pa.us, thomas.munro@gmail.com, melanieplageman@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Unstable tests for recovery conflict handling
In-Reply-To: <20220428013134.gahwtxwfuu6gwfwe@alap3.anarazel.de>
References: <E1nca5h-000nN0-6f@gemulon.postgresql.org> <394950.1651077914@sss.pgh.pa.us> <447238.1651082925@sss.pgh.pa.us> <20220428013134.gahwtxwfuu6gwfwe@alap3.anarazel.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox