pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix for make unportability
Date: Wed, 13 Jul 2022 09:45:04 +0200
Message-ID: <20220713074504.wknclwsjlvbz4edl@alvherre.pgsql> (raw)
In-Reply-To: <E1oBWdd-002Yjy-Lt@gemulon.postgresql.org>

On 2022-Jul-13, Peter Eisentraut wrote:

> Fix for make unportability
> 
> 88dad06b47eb80f699211c9b0b7a1c6d9016ad19 contains a make $(shell)
> construct that apparently confuses older GNU make versions (possibly
> because of the # inside the shell command?).  This construct, which
> would allow # comments inside LINGUAS files, was adapted from gettext
> recommendations, but we don't actually need that functionality, so
> sidestep this whole issue by just using plain "cat".

I suppose if we're getting rid of Make soon, it's not really very useful
to make this more make-ish:

  AVAIL_LANGUAGES := $(file <$(srcdir)/po/LINGUAS)

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/





view thread (3+ messages)  latest in thread

Message-ID: <20220713074504.wknclwsjlvbz4edl@alvherre.pgsql>
Permalink:  ../20220713074504.wknclwsjlvbz4edl@alvherre.pgsql/
Also on:    postgresql.org/message-id/20220713074504.wknclwsjlvbz4edl@alvherre.pgsql

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: alvherre@alvh.no-ip.org, peter@eisentraut.org
  Subject: Re: pgsql: Fix for make unportability
  In-Reply-To: <20220713074504.wknclwsjlvbz4edl@alvherre.pgsql>
  References: <E1oBWdd-002Yjy-Lt@gemulon.postgresql.org> <20220713074504.wknclwsjlvbz4edl@alvherre.pgsql>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox