pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Pavel Stehule <pavel.stehule@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Default to hidden visibility for extension libraries where possi
Date: Tue, 19 Jul 2022 08:31:49 -0700
Message-ID: <20220719153149.lhbir3wh4sgfkfe7@awork3.anarazel.de> (raw)
In-Reply-To: <20220719142807.2zex4cczycc5nqq5@alvherre.pgsql>
References: <1057666.1658238352@sss.pgh.pa.us>
	<20220719142807.2zex4cczycc5nqq5@alvherre.pgsql>

Hi,

On 2022-07-19 16:28:07 +0200, Alvaro Herrera wrote:
> Anyway, the minimal patch that makes plpgsql_check tests pass is
> attached.  This seems a bit random.  Maybe it'd be better to have a
> plpgsql_internal.h with functions that are exported only for plpgsql
> itself, and keep plpgsql.h with a set of functions, all marked
> PGDLLEXPORT, that are for external use.

It does seem a bit random. But I think we probably should err on the side of
adding more declarations, rather than the oposite.

I like the plpgsql_internal.h idea, but probably done separately?

Greetings,

Andres Freund





view thread (27+ messages)  latest in thread

Message-ID: <20220719153149.lhbir3wh4sgfkfe7@awork3.anarazel.de>
Permalink:  ../20220719153149.lhbir3wh4sgfkfe7@awork3.anarazel.de/
Also on:    postgresql.org/message-id/20220719153149.lhbir3wh4sgfkfe7@awork3.anarazel.de

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de, alvherre@alvh.no-ip.org, tgl@sss.pgh.pa.us, pavel.stehule@gmail.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: pgsql: Default to hidden visibility for extension libraries where possi
  In-Reply-To: <20220719153149.lhbir3wh4sgfkfe7@awork3.anarazel.de>
  References: <1057666.1658238352@sss.pgh.pa.us> <20220719142807.2zex4cczycc5nqq5@alvherre.pgsql> <20220719153149.lhbir3wh4sgfkfe7@awork3.anarazel.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox