From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Thomas Munro <tmunro@postgresql.org>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Prefetch data referenced by the WAL, take II.
Date: Sun, 4 Sep 2022 09:54:50 +0200
Message-ID: <20220904075450.6g4nm4hralyw3tab@alvherre.pgsql> (raw)
In-Reply-To: <E1ncMoW-000hhv-4s@gemulon.postgresql.org>
On 2022-Apr-07, Thomas Munro wrote:
> Prefetch data referenced by the WAL, take II.
I propose a small wording change in guc.c,
inline patch 1: src/backend/utils/misc/guc.c (+1/-1 lines) download inline-1.patchdiff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.cindex 9fbbfb1be5..9803741708 100644--- a/src/backend/utils/misc/guc.c+++ b/src/backend/utils/misc/guc.c@@ -2840,7 +2840,7 @@ static struct config_int ConfigureNamesInt[] =
{
{"wal_decode_buffer_size", PGC_POSTMASTER, WAL_RECOVERY,
gettext_noop("Maximum buffer size for reading ahead in the WAL during recovery."),
- gettext_noop("This controls the maximum distance we can read ahead in the WAL to prefetch referenced blocks."),+ gettext_noop("This controls the maximum distance we can read ahead in the WAL to prefetch data blocks referenced therein."),
GUC_UNIT_BYTE
},
&wal_decode_buffer_size,
"referenced blocks" seems otherwise a bit unclear to me. Other wording
suggestions welcome. I first thought of "...to prefetch referenced data
blocks", which is probably OK too.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"Siempre hay que alimentar a los dioses, aunque la tierra esté seca" (Orual)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: alvherre@alvh.no-ip.org, tmunro@postgresql.org, pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Prefetch data referenced by the WAL, take II.
In-Reply-To: <20220904075450.6g4nm4hralyw3tab@alvherre.pgsql>
References: <E1ncMoW-000hhv-4s@gemulon.postgresql.org> <20220904075450.6g4nm4hralyw3tab@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox